Page MenuHomeSolus

Change library from pysrt to srt
Needs RevisionPublic

Authored by infinitymdm on Fri, Nov 11, 1:46 AM.

Details

Reviewers
algent
Group Reviewers
Triage Team
Summary

Patch subliminal to use srt instead of pysrt.

Since subliminal is the only package that depends on the apparently unmaintained pysrt library, this patch would allow us to deprecate pysrt and replace it with srt.
To be completely honest, I don't really use this sort of software. It needs thorough testing by someone who will actually use it.

Depends on T10431 python-srt.

Test Plan

Execute subliminal --help in terminal

Diff Detail

Repository
R2972 subliminal
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4586
Build 4586: arc lint + arc unit

Event Timeline

infinitymdm created this revision.Fri, Nov 11, 1:46 AM
infinitymdm requested review of this revision.Fri, Nov 11, 1:46 AM

Bump release number

algent requested changes to this revision.Fri, Nov 11, 5:17 PM
algent added a subscriber: algent.

Marking this as "Request Changes", because python-srt is not accepted yet for inclusion, to avoid accidental landing.

This revision now requires changes to proceed.Fri, Nov 11, 5:17 PM
infinitymdm edited the summary of this revision. (Show Details)Fri, Nov 11, 7:01 PM