Paths

Table of Contentst

Differential D13746

Initial inclusion of SolveSpace Resolves T5574
ClosedPublic
Actions

Authored by Icosahunter on Nov 9 2022, 2:16 AM.

Tags

None

Referenced Files

	F11024632: D13746.diff
	Tue, Aug 8, 10:53 PM

	F11005770: D13746.diff
	Tue, Aug 1, 10:00 AM

	F10918197: D13746.id33564.diff
	Jul 8 2023, 8:44 PM

	F10918196: D13746.id.diff
	Jul 8 2023, 8:44 PM

	F10918194: D13746.id33587.diff
	Jul 8 2023, 8:44 PM

	F10884565: D13746.id.diff
	Jun 25 2023, 12:44 AM

	F10879231: D13746.id33587.diff
	Jun 21 2023, 9:40 PM

	F10878452: D13746.id33564.diff
	Jun 21 2023, 9:11 AM

View All 27 Files

Subscribers

Tokens

"Mountain of Wealth" token, awarded by Jacek."Cup of Joe" token, awarded by infinitymdm.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T5574: SolveSpace

Commits

R5638:56a301a2b16b: Initial inclusion of SolveSpace Resolves T5574

Summary

Initial inclusion of SolveSpace
Resolves T5574

Test Plan

Launch solvespace, create shape, add constraint(s), save file, reopen file, check shape and constraints are still there.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4581
Build 4581: arc lint + arc unit

Event Timeline

Icosahunter created this revision.Nov 9 2022, 2:16 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 9 2022, 2:16 AM

Harbormaster completed remote builds in B4576: Diff 33564.Nov 9 2022, 2:16 AM

Icosahunter requested review of this revision.Nov 9 2022, 2:16 AM

Icosahunter edited the summary of this revision. (Show Details)Nov 9 2022, 2:18 AM

Icosahunter added a task: T5574: SolveSpace.

infinitymdm awarded a token.Nov 9 2022, 2:20 AM

Please fix component and clean builddeps.

package.yml
9	`component : multimedia.graphics` Only one component per package
16	`pkgconfig(cairo)` not needed because it is already pulled in by `pkgconfig(gtkmm-3.0)`
20	`pkgconfig(zlib)` not needed because it is part of `system.devel` component

This revision now requires changes to proceed.Nov 9 2022, 8:52 AM

Actually let set it to office component like our FreeCAD.
component : office

Jacek awarded a token.Nov 9 2022, 12:26 PM

Removed second component.
Removed redundant dependencies.
Added trailing newline.

Harbormaster completed remote builds in B4581: Diff 33573.Nov 10 2022, 1:12 AM

Changes made

I have applied all the suggested changes, so I believe™ this package should be good to go.

Need another rebuild.

pspec_x86_64.xml
10	You need to rebuild this again, because the changes you made to package.yml are not present in `pspec_x86_64.xml`. This should be `<PartOf>office</PartOf>`. Don't edit this manually.

This revision now requires changes to proceed.Nov 11 2022, 3:13 PM

Rebuilt package to update files

Harbormaster completed remote builds in B4590: Diff 33587.Nov 12 2022, 1:55 AM

In D13746#235806, @algent wrote:

Need another rebuild.

Done

LGTM, thanks!

This revision is now accepted and ready to land.Nov 12 2022, 1:49 PM

Closed by commit R5638:56a301a2b16b: Initial inclusion of SolveSpace Resolves T5574 (authored by Icosahunter, committed by algent). · Explain WhyNov 12 2022, 1:51 PM

This revision was automatically updated to reflect the committed changes.

algent added a commit: R5638:56a301a2b16b: Initial inclusion of SolveSpace Resolves T5574.

Revision Contents
Changeset List

Path

Size

5 lines

1 line

2 lines

279 lines

23 lines

abi_used_symbols

683 lines

21 lines

pspec_x86_64.xml

151 lines

Diff 33573

MAINTAINERS.md

Loading...

Makefile

Loading...

abi_libs

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...