Page MenuHomeSolus

Initial inclusion of SolveSpace Resolves T5574
ClosedPublic

Authored by Icosahunter on Wed, Nov 9, 2:16 AM.

Details

Summary

Initial inclusion of SolveSpace
Resolves T5574

Test Plan

Launch solvespace, create shape, add constraint(s), save file, reopen file, check shape and constraints are still there.

Diff Detail

Repository
R5638 solvespace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Icosahunter created this revision.Wed, Nov 9, 2:16 AM
Icosahunter requested review of this revision.Wed, Nov 9, 2:16 AM
Icosahunter edited the summary of this revision. (Show Details)Wed, Nov 9, 2:18 AM
algent requested changes to this revision.Wed, Nov 9, 8:52 AM
algent added a subscriber: algent.

Please fix component and clean builddeps.

package.yml
9

component : multimedia.graphics

Only one component per package

16

pkgconfig(cairo) not needed because it is already pulled in by pkgconfig(gtkmm-3.0)

20

pkgconfig(zlib) not needed because it is part of system.devel component

This revision now requires changes to proceed.Wed, Nov 9, 8:52 AM
algent added a comment.Wed, Nov 9, 8:59 AM

Actually let set it to office component like our FreeCAD.
component : office

Jacek awarded a token.Wed, Nov 9, 12:26 PM

Removed second component.
Removed redundant dependencies.
Added trailing newline.

Icosahunter marked 3 inline comments as done.Thu, Nov 10, 1:23 AM

Changes made

I have applied all the suggested changes, so I believe™ this package should be good to go.

algent requested changes to this revision.Fri, Nov 11, 3:13 PM

Need another rebuild.

pspec_x86_64.xml
11

You need to rebuild this again, because the changes you made to package.yml are not present in pspec_x86_64.xml.
This should be <PartOf>office</PartOf>. Don't edit this manually.

This revision now requires changes to proceed.Fri, Nov 11, 3:13 PM

Rebuilt package to update files

Need another rebuild.

Done

algent accepted this revision.Sat, Nov 12, 1:49 PM

LGTM, thanks!

This revision is now accepted and ready to land.Sat, Nov 12, 1:49 PM
This revision was automatically updated to reflect the committed changes.