Details
- Reviewers
Staudey - Group Reviewers
Triage Team - Commits
- R4591:0b2aadbfd7d0: Update fmt to 9.1.0
Rebuild dolphin-emu against updated fmt and run a game
Diff Detail
- Repository
- R4591 fmt
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
You're going to need to test that *every* revdep builds and runs with the new version.
CC @davidjharder since he was also working on updating FMT and I'd hate for there to be duplicated effort on this.
Thanks for the heads up. I snagged on rebuilding kodi and mkvtoolnix, haven't made any headway since
Kodi does have an option to use its own fmt, if that ends up being necessary. The latest git definitely has support for fmt 9.1.0, so it may be an issue of needing to wait for a release that supports it (or apply the relevant patch, as the commit that updates it changes one line).
It seems like a big thing would be updating the relevant software, as most of them seem to have been adapted in newer updates if they don't just work.
I've managed to build everything except for Kodi. waybar and mkvtoolnix just need to be updated in order to work. I can submit updated packages for both of them.
@Phantop: You could find a single patch to fix the build for Kodi with fmt 9.1.0? Asking because I got into a bit of a patch mess yesterday when I took a look at it ?
FWIW I'm all for a simple patch. They're at beta 1 for their next release now, which could still mean two months (or more) until the final release, if you go by past schedules.
@Phantop @davidjharder Looks like Kodi 19.5 contains changes to fix compatibility with fmt >= 9.0
I just landed that diff, so the major blocker should be out of the way now.
Alright! So, assuming that Kodi works, just mkvtoolnix and Waybar need to be updated. I can submit the former shortly, however Waybar needs to be updated, but wants newer versions of spdlog and jsoncpp as well as needs some changes to the stateless config patch. I'll look into updating those, though there is the option of enabling networking and having Waybar build its own (though I imagine that's preferable to avoid).
I'll test real quick whether Kodi works. Hopefully it's all good.
I don't know if @davidjharder already had some work on waybar (which I think was the original package that wanted fmt 9). In any case, yes, if possible I'd like to use system packages. Unfortunately I haven't found the time yet this week to look into it.
I can't do anything about waybar & friends until well after New Year's. Traveling for the holidays
@davidjharder Oh, no worries. I just wanted to make sure we weren't stepping on your toes here by duplicating work. Enjoy your travels! ?
So, spdlog and jsoncpp seem to just need rebuilds when the versions are bumped? I'm a little reluctant to submit updates for the latter, though, as some of the revdeps take a very long time to build and I don't have access to a computer that can just sit and wait for everything to build for that long. Similar deal with Kodi, where it seems to be building fine but takes simply so long that I can't know for sure.
@Phantop I'll try to look at the whole thing this weekend (depending on how much time I have next to New Year's Eve obligations).
P.S. Kodi built fine with the new version, I just tested.
This is the full list of packages that needs to be validated with new version of fmt.
yuzu waybar openimageio mpd mkvtoolnix kodi dolphin-emu cherrytree 0ad
Some of these you already tested. Please test the rest. If any package need to be updated in order to work with new fmt then please submit the update and add it to this stack.
@infinitymdm Cheers!
I have most of the remaining stuff ready now, except for some of the big chonkers in the jsoncpp rebuilds. Will (try) to compile those over the next couple of hours, and then push soon-ish after the sync.