Page MenuHomeSolus

Update fmt to 9.1.0
Needs RevisionPublic

Authored by Phantop on Nov 8 2022, 3:59 PM.


Group Reviewers
Triage Team


Test Plan

Rebuild dolphin-emu against updated fmt and run a game

Diff Detail

R4591 fmt
No Linters Available
No Unit Test Coverage
Build Status
Buildable 4572
Build 4572: arc lint + arc unit

Event Timeline

Phantop created this revision.Nov 8 2022, 3:59 PM
Phantop requested review of this revision.Nov 8 2022, 3:59 PM

You're going to need to test that *every* revdep builds and runs with the new version.

CC @davidjharder since he was also working on updating FMT and I'd hate for there to be duplicated effort on this.

ReillyBrogan requested changes to this revision.Nov 8 2022, 4:14 PM
This revision now requires changes to proceed.Nov 8 2022, 4:14 PM

Thanks for the heads up. I snagged on rebuilding kodi and mkvtoolnix, haven't made any headway since

Kodi does have an option to use its own fmt, if that ends up being necessary. The latest git definitely has support for fmt 9.1.0, so it may be an issue of needing to wait for a release that supports it (or apply the relevant patch, as the commit that updates it changes one line).

It seems like a big thing would be updating the relevant software, as most of them seem to have been adapted in newer updates if they don't just work.

I've managed to build everything except for Kodi. waybar and mkvtoolnix just need to be updated in order to work. I can submit updated packages for both of them.

@Phantop: You could find a single patch to fix the build for Kodi with fmt 9.1.0? Asking because I got into a bit of a patch mess yesterday when I took a look at it 😆
FWIW I'm all for a simple patch. They're at beta 1 for their next release now, which could still mean two months (or more) until the final release, if you go by past schedules.