Page MenuHomeSolus

Update upx to 4.0.0
ClosedPublic

Authored by chax on Nov 8 2022, 1:19 AM.

Details

Summary

Update upx to 4.0.0
Changelog can be found here

Test Plan
  • install upx and try to use it on few executables
  • try to build some golang program into a binary executable
  • compress it with upx and try to run it
  • try to build the same program for arm architecture
  • compress it with upx, transfer it on arm target and run it

Diff Detail

Repository
R4826 upx
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Nov 8 2022, 1:19 AM
chax requested review of this revision.Nov 8 2022, 1:19 AM
Staudey accepted this revision.Nov 8 2022, 9:32 PM
Staudey added a subscriber: Staudey.

LGTM, thanks!

This revision is now accepted and ready to land.Nov 8 2022, 9:32 PM
Staudey requested changes to this revision.Nov 8 2022, 9:39 PM

Actually, on second thought:

package.yml
10–11

This no longer seems to be necessary, even though I see nothing about it in their changelog

This revision now requires changes to proceed.Nov 8 2022, 9:39 PM

Yeah, seems like they use vendored versions of those dependencies now. https://github.com/upx/upx/commit/61e1366122f8d1b9e2434a8103e7af00a35ea902

chax updated this revision to Diff 33597.Sat, Nov 12, 5:03 PM

Removed ucl as build dependency.

chax added a comment.Sat, Nov 12, 5:09 PM

I tried to find an option to use system's version of ucl library, but they added ucl as vendored lib because they use updated version of ucl.
ucl library was added to Solus repo for sole purpose of having it as dependency library for upx, so now that i removed it from upx, do we even need it in repo?

Staudey accepted this revision.Sat, Nov 12, 8:55 PM

Yeah, I also saw that they kept that vendored library more up-to-date than the standalone. As you said, since it's only used for this specific purpose I think we can get rid of our separate package for it afterwards.

This revision is now accepted and ready to land.Sat, Nov 12, 8:55 PM
This revision was automatically updated to reflect the committed changes.