Page MenuHomeSolus

Initial inclusion of citra
ClosedPublic

Authored by infinitymdm on Nov 6 2022, 11:23 PM.

Details

Summary

Initial inclusion of Citra, a 3DS emulator. Fixes T10421

Test Plan
  • Launch Citra from GUI
  • Tweak some settings and make sure they stick
  • Load a game (that you dumped yourself, legally) and make sure things mostly look ok

Diff Detail

Repository
R5631 citra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

infinitymdm created this revision.Nov 6 2022, 11:23 PM
infinitymdm requested review of this revision.Nov 6 2022, 11:23 PM
infinitymdm retitled this revision from Initial inclusion of citra. Fixes T10421 to Initial inclusion of citra.Nov 7 2022, 2:05 AM
infinitymdm edited the summary of this revision. (Show Details)
Staudey requested changes to this revision.Nov 7 2022, 9:50 PM
Staudey added a subscriber: Staudey.

Just a couple little things, otherwise looks good to me.

package.yml
10

There is some unnecessary whitespace hidden at the end here.

17

I'd prefer it if you would use something like this, to on the one hand simplify a bit, and on the other hand separate the steps logically:

setup      : |
    %cmake_ninja -DCMAKE_BUILD_TYPE=Release
build      : |
    %ninja_build
install    : |
    %ninja_install
pspec_x86_64.xml
43

If you build this package with our own robin-map, does it not install these files?
In any case they should be excluded/removed from the package.

This revision now requires changes to proceed.Nov 7 2022, 9:50 PM
algent added a subscriber: algent.Nov 7 2022, 9:59 PM

Please add a MAINTAINERS.md file.

package.yml
11

The component should be after license.

Staudey added inline comments.Nov 7 2022, 10:23 PM
pspec_x86_64.xml
43

-DDYNARMIC_NO_BUNDLED_ROBIN_MAP=TRUE should do the trick (and I just saw that we have the same issue with the yuzu package

Thanks for catching those issues. I'll have things fixed up in a few minutes.

Fixes to build recipe

  • Swap to ninja build
  • Add dependency on robin-map to remove unneeded -devel package
  • Add robin-map build flag
  • Add MAINTAINERS.md
infinitymdm marked 5 inline comments as done.Nov 7 2022, 11:37 PM

Those fixes should be good now. I'll add the robin-map stuff to yuzu when I update it on Wednesday - since they also do nightly builds, I find that Wednesdays strike a good balance between testing time and recency.

Staudey accepted this revision.Nov 7 2022, 11:55 PM

Well, that was fast ๐Ÿ˜†

LGTM now, thanks!

We'll survive until the next yuzu update for the robin-map changes. ^^
For some reason I never really paid attention to those -devel files in that case.
A Wednesday update schedule sounds reasonable for these kinds of packages, true.

This revision is now accepted and ready to land.Nov 7 2022, 11:55 PM
This revision was automatically updated to reflect the committed changes.