Initial inclusion of Citra, a 3DS emulator. Fixes T10421
Details
Details
- Reviewers
Staudey - Group Reviewers
Triage Team - Maniphest Tasks
- T10421: Citra 3DS Emulator
- Commits
- R5631:2db86597794e: Initial inclusion of citra
- Launch Citra from GUI
- Tweak some settings and make sure they stick
- Load a game (that you dumped yourself, legally) and make sure things mostly look ok
Diff Detail
Diff Detail
- Repository
- R5631 citra
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Just a couple little things, otherwise looks good to me.
| package.yml | ||
|---|---|---|
| 10 | There is some unnecessary whitespace hidden at the end here. | |
| 17 | I'd prefer it if you would use something like this, to on the one hand simplify a bit, and on the other hand separate the steps logically: setup : |
%cmake_ninja -DCMAKE_BUILD_TYPE=Release
build : |
%ninja_build
install : |
%ninja_install | |
| pspec_x86_64.xml | ||
| 43 | If you build this package with our own robin-map, does it not install these files? | |
Comment Actions
Please add a MAINTAINERS.md file.
| package.yml | ||
|---|---|---|
| 11 | The component should be after license. | |
| pspec_x86_64.xml | ||
|---|---|---|
| 43 | -DDYNARMIC_NO_BUNDLED_ROBIN_MAP=TRUE should do the trick (and I just saw that we have the same issue with the yuzu package | |
Comment Actions
Fixes to build recipe
- Swap to ninja build
- Add dependency on robin-map to remove unneeded -devel package
- Add robin-map build flag
- Add MAINTAINERS.md
Comment Actions
Those fixes should be good now. I'll add the robin-map stuff to yuzu when I update it on Wednesday - since they also do nightly builds, I find that Wednesdays strike a good balance between testing time and recency.
Comment Actions
Well, that was fast ?
LGTM now, thanks!
We'll survive until the next yuzu update for the robin-map changes. ^^
For some reason I never really paid attention to those -devel files in that case.
A Wednesday update schedule sounds reasonable for these kinds of packages, true.