Fix build deps.
Details
Diff Detail
- Repository
- R326 0ad
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 4541 Build 4541: arc lint + arc unit
Event Timeline
| package.yml | ||
|---|---|---|
| 35 | alphabetical-ize | |
@ketronix_dev what @joebonrichie meant with alphabetical-ize is to move pkgconfig(freetype2) from after pkgconfig(x11) to after pkgconfig(fmt).
So the order should be:
builddeps :
- pkgconfig(fmt)
- pkgconfig(freetype2)
- pkgconfig(gl)
- etc ...The order rule is from 0 to 9, A to Z and a to z.
After you finish the changes. don't use git commit and then arc diff, but git commit --amend and then arc diff.
If not, you will duplicate this diff again.
You can simply update your earlier revision (D13639) with arc diff --update. There is no need to create this new one.
Btw, my question about why you excluded that .destkop-file patch still stands.
This patch does not apply. Specifically, my build ends with an error when this patch is applied. But if you remove it the game builds, and works as it should. It is because of these two reasons I thought that this patch will be unnecessary.
That just means the patch needs to be rebased. It's a pretty common action when doing package updates.
Say you click on a desktop icon for an application in a DE (GNOME, for example). Typically this starts up a process that's a direct child of this action and if this process is the one rendering a window then the DE knows to associate that window with the application you just clicked (so if you clicked Firefox for example the DE will change the UI of the Firefox icon so that it tracks the newly opened Firefox window). In some instances there's a more complex startup process for that application and the process rendering the UI is not the direct process that the DE started. If this happens the DE won't be able to know that the window that just launched is for the application the user just clicked. In this case such applications usually set a property on that window (the WMClass) and then the DE can compare this with all of the .desktop files it has registered and thus know that the window belongs to one of those applications.