Page MenuHomeSolus

Add pkgconfig(freetype2) and rebuild with solbuild
AbandonedPublic

Authored by ketronix_dev on Nov 4 2022, 2:18 PM.

Details

Reviewers
Staudey
Group Reviewers
Triage Team
Summary

Fix build deps.

Test Plan

Tested on my system.

Diff Detail

Repository
R326 0ad
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4541
Build 4541: arc lint + arc unit

Event Timeline

ketronix_dev created this revision.Nov 4 2022, 2:18 PM
ketronix_dev requested review of this revision.Nov 4 2022, 2:18 PM
joebonrichie added inline comments.
package.yml
35

alphabetical-ize

ketronix_dev marked an inline comment as done.Nov 4 2022, 2:46 PM

I was told in the last revision to do this.

algent added a subscriber: algent.Nov 4 2022, 4:35 PM

@ketronix_dev what @joebonrichie meant with alphabetical-ize is to move pkgconfig(freetype2) from after pkgconfig(x11) to after pkgconfig(fmt).
So the order should be:

builddeps  :
    - pkgconfig(fmt)
    - pkgconfig(freetype2)
    - pkgconfig(gl)
    - etc ...

The order rule is from 0 to 9, A to Z and a to z.

algent added a comment.Nov 4 2022, 4:38 PM

After you finish the changes. don't use git commit and then arc diff, but git commit --amend and then arc diff.
If not, you will duplicate this diff again.

Staudey requested changes to this revision.Nov 4 2022, 4:38 PM
Staudey added a subscriber: Staudey.

You can simply update your earlier revision (D13639) with arc diff --update. There is no need to create this new one.

Btw, my question about why you excluded that .destkop-file patch still stands.

This revision now requires changes to proceed.Nov 4 2022, 4:38 PM

This patch does not apply. Specifically, my build ends with an error when this patch is applied. But if you remove it the game builds, and works as it should. It is because of these two reasons I thought that this patch will be unnecessary.

This patch does not apply. Specifically, my build ends with an error when this patch is applied. But if you remove it the game builds, and works as it should. It is because of these two reasons I thought that this patch will be unnecessary.

That just means the patch needs to be rebased. It's a pretty common action when doing package updates.

I don't quite understand the point of that patch. What's it for?

I don't quite understand the point of that patch. What's it for?

Say you click on a desktop icon for an application in a DE (GNOME, for example). Typically this starts up a process that's a direct child of this action and if this process is the one rendering a window then the DE knows to associate that window with the application you just clicked (so if you clicked Firefox for example the DE will change the UI of the Firefox icon so that it tracks the newly opened Firefox window). In some instances there's a more complex startup process for that application and the process rendering the UI is not the direct process that the DE started. If this happens the DE won't be able to know that the window that just launched is for the application the user just clicked. In this case such applications usually set a property on that window (the WMClass) and then the DE can compare this with all of the .desktop files it has registered and thus know that the window belongs to one of those applications.

algent abandoned this revision.Nov 4 2022, 7:05 PM

Abandon in favour of D13639