Page MenuHomeSolus

Update graalvm to 22.3.0
ClosedPublic

Authored by oly on Nov 2 2022, 5:08 PM.

Details

Summary

Update graal mx tools and the java version used in building.

Test Plan

Ran /usr/share/graalvm/bin/java files/hello-world.java
to make sure it could still compile

Diff Detail

Repository
R5454 graalvm
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

oly created this revision.Nov 2 2022, 5:08 PM
oly requested review of this revision.Nov 2 2022, 5:08 PM
algent requested changes to this revision.Nov 2 2022, 8:24 PM
algent added a subscriber: algent.
algent added inline comments.
package.yml
16โ€“17

glibc-devel is not needed as builddep because it is part of system.devel.
I built this localy and I get missing symbols for:

libXtst.so.6
libXi.so.6
libasound.so.2

To fix this I suggest you to add pkgconfig(alsa) and pkgconfig(xtst) to builddeps.

This revision now requires changes to proceed.Nov 2 2022, 8:24 PM
Staudey added a subscriber: Staudey.Nov 2 2022, 8:29 PM
Staudey added inline comments.
package.yml
12

While we're at it, and since I only noticed this just now, can we change the summary and description to something like:

summary    : High-performance JDK distribution
description: |
    GraalVM is a high-performance JDK distribution designed to accelerate the execution of applications written in Java and other JVM languages along with support for JavaScript, Ruby, Python, and a number of other popular languages

(or at your discretion something else, but something that isn't open-ended like the current description or pure marketing language like the summary ๐Ÿ˜)

oly updated this revision to Diff 33489.Nov 3 2022, 8:49 AM

Adjust description and modify build dependencies as per packaging review.

oly added a comment.Nov 3 2022, 8:49 AM

Okay made the description changes, I probably got the info from there website as I was not sure what to call it as it works with all sorts of languages.

I have updated the buildeps, I am guessing they are not needed for it to function it seemed to build and work when I tested.

algent accepted this revision.Nov 3 2022, 8:15 PM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 3 2022, 8:15 PM
Closed by commit R5454:7207aa8bed1d: Update graalvm to 22.3.0 (authored by oly, committed by algent). ยท Explain WhyNov 3 2022, 8:15 PM
This revision was automatically updated to reflect the committed changes.