Page MenuHomeSolus
Differential D13673

Update to 1.32.0
ClosedPublic
Actions

Authored by xulongwu4 on Oct 26 2022, 3:15 AM.
Tags
None
Referenced Files
F11036262: D13673.id33427.diff
Wed, Aug 9, 7:09 PM
F11036261: D13673.id33418.diff
Wed, Aug 9, 7:09 PM
F11036260: D13673.id.diff
Wed, Aug 9, 7:09 PM
F11036259: D13673.id33403.diff
Wed, Aug 9, 7:09 PM
F11026791: D13673.diff
Wed, Aug 9, 3:00 AM
F11016476: D13673.id.diff
Sat, Aug 5, 6:11 PM
F10890068: D13673.diff
Jun 28 2023, 10:26 AM
F10876858: D13673.diff
Jun 20 2023, 2:05 PM
View All 20 Files
Subscribers
Staudey

Details

Reviewers
Staudey
Group Reviewers
Triage Team
Commits
R1955:baa9f0e97dbb: Update to 1.32.0
Summary

Update to 1.32.0.

Changelog

Test Plan

Used it to log into my window manager sessions.

Diff Detail

Repository
R1955 lightdm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4490
Build 4490: arc lint + arc unit

Event Timeline

xulongwu4 created this revision.Oct 26 2022, 3:15 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptOct 26 2022, 3:15 AM
xulongwu4 requested review of this revision.Oct 26 2022, 3:15 AM
Harbormaster completed remote builds in B4490: Diff 33403.Oct 26 2022, 3:15 AM
Staudey requested changes to this revision.Oct 27 2022, 8:40 PM
Staudey added a subscriber: Staudey.

Looks mostly good to me, just some smaller nitpicks.

package.yml
25

Can be replaced with pkgconfig(libgcrypt)

39

can you add --enable-gtk-doc so we get our docs-subpackage back?

This revision now requires changes to proceed.Oct 27 2022, 8:40 PM
xulongwu4 updated this revision to Diff 33418.Oct 28 2022, 1:24 PM

Enable gtk doc

Harbormaster completed remote builds in B4499: Diff 33418.Oct 28 2022, 1:24 PM
xulongwu4 marked 2 inline comments as done.Oct 28 2022, 1:24 PM

Updated according to the suggestion.

Staudey accepted this revision.Oct 29 2022, 1:11 PM

Thanks! LGTM now. I've waited until after the sync so we can get some more testing in before it hits Stable.

This revision is now accepted and ready to land.Oct 29 2022, 1:11 PM
Closed by commit R1955:baa9f0e97dbb: Update to 1.32.0 (authored by xulongwu4, committed by Staudey). · Explain WhyOct 29 2022, 1:12 PM
This revision was automatically updated to reflect the committed changes.
Staudey added a commit: R1955:baa9f0e97dbb: Update to 1.32.0.

Revision Contents
Changeset List

Diff 33403

View Options

abi_used_symbols

Loading...
View Options

files/0001-Fix-build-failure.patch

Loading...
View Options

files/dbus-stateless.patch

Loading...
View Options

files/series

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.