Initial commit, first build
AbandonedPublic
Actions

Authored by ketronix_dev on Oct 24 2022, 9:43 AM.

Details

Reviewers

None

Group Reviewers

Triage Team

Summary

Requesting A Package

Name: gnome-text-editor
Homepage: https://apps.gnome.org/ru/app/org.gnome.TextEditor/
Why should it be added to the repository? : This application is the modern official replacement for the obsolete gedit. It has a modern interface, and more advanced functionality.
This is opensource? : Yes, and is also being developed as part of the GNOME project.
Who will use: I'm sure it will be used by the vast majority of Solus Gnome users.

Test Plan

Tested on my system.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4483
Build 4483: arc lint + arc unit

Event Timeline

ketronix_dev created this revision.Oct 24 2022, 9:43 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 24 2022, 9:43 AM

ketronix_dev requested review of this revision.Oct 24 2022, 9:43 AM

Harbormaster completed remote builds in B4483: Diff 33391.Oct 24 2022, 9:43 AM

Please first file a package inclusion request and wait for it to be accepted, as described here: https://getsol.us/articles/packaging/request-a-package/en/ and here: https://getsol.us/articles/packaging/submitting-a-package/en/#prior-to-patch-submission

After the inclusion request has been accepted you can submit your diff/patch and reference the inclusion request like Fixes T...... (with the task number of the request)

I'll add just a couple quick notes about the patch right now, because I saw those issues while scrolling down, and you can fix them for the proper submission, after the inclusion request. (those are by no means comprehensive, just mentioning some things in passing)

package.yml
6	This is not the correct license. From looking at the repository the correct one is `GPL-3.0-or-later` That's why the `# CHECK ME` note is there. The license has to be manually checked and corrected. Unfortunately we don't have real license detection.
12	Not necessary, as `libadwaita-devel` already depends on it.
17	Not necessary as e.g. `libgtksourceview5-devel` already depends on it
20	Please use `pkgconfig(gtksourceview-5)` instead. Dependency `libgtksourceview5` is not necessary because the -devel package depends on it.
21	Please use `pkgconfig(libadwaita-1)` instead. Dependency `libadwaita` is not necessary because the -devel package depends on it.