Page MenuHomeSolus

Initial commit, first build
AbandonedPublic

Authored by ketronix_dev on Oct 24 2022, 9:43 AM.
Tags
None
Referenced Files
F11005863: D13666.diff
Tue, Aug 1, 10:49 AM
F10887667: D13666.id.diff
Jun 26 2023, 3:18 PM
F10863263: D13666.id33391.diff
Jun 17 2023, 1:36 AM
F10856974: D13666.diff
Jun 15 2023, 2:43 AM
F10805944: D13666.id33391.diff
May 29 2023, 10:52 PM
F10788729: D13666.diff
May 26 2023, 5:16 PM
F10746354: D13666.id.diff
May 15 2023, 10:09 AM
F10746351: D13666.id33391.diff
May 15 2023, 10:08 AM

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Requesting A Package

Name: gnome-text-editor
Homepage: https://apps.gnome.org/ru/app/org.gnome.TextEditor/
Why should it be added to the repository? : This application is the modern official replacement for the obsolete gedit. It has a modern interface, and more advanced functionality.
This is opensource? : Yes, and is also being developed as part of the GNOME project.
Who will use: I'm sure it will be used by the vast majority of Solus Gnome users.
Test Plan

Tested on my system.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4483
Build 4483: arc lint + arc unit

Event Timeline

Staudey added a subscriber: Staudey.

Please first file a package inclusion request and wait for it to be accepted, as described here: https://getsol.us/articles/packaging/request-a-package/en/ and here: https://getsol.us/articles/packaging/submitting-a-package/en/#prior-to-patch-submission

After the inclusion request has been accepted you can submit your diff/patch and reference the inclusion request like Fixes T...... (with the task number of the request)

I'll add just a couple quick notes about the patch right now, because I saw those issues while scrolling down, and you can fix them for the proper submission, after the inclusion request. (those are by no means comprehensive, just mentioning some things in passing)

package.yml
6

This is not the correct license. From looking at the repository the correct one is GPL-3.0-or-later

That's why the # CHECK ME note is there. The license has to be manually checked and corrected. Unfortunately we don't have real license detection.

12

Not necessary, as libadwaita-devel already depends on it.

17

Not necessary as e.g. libgtksourceview5-devel already depends on it

20

Please use pkgconfig(gtksourceview-5) instead. Dependency libgtksourceview5 is not necessary because the -devel package depends on it.

21

Please use pkgconfig(libadwaita-1) instead. Dependency libadwaita is not necessary because the -devel package depends on it.