element: Remove electron override
ClosedPublic
Actions

Authored by ReillyBrogan on Sep 6 2022, 3:49 PM.

Tags

None

Referenced Files

	F11005794: D13551.diff
	Tue, Aug 1, 10:05 AM

	F10866895: D13551.diff
	Jun 17 2023, 5:55 PM

	F10843418: D13551.id33131.diff
	Jun 10 2023, 5:49 PM

	F10840626: D13551.id33128.diff
	Jun 10 2023, 2:30 AM

	F10838342: D13551.diff
	Jun 9 2023, 1:42 PM

	F10790529: D13551.id.diff
	May 26 2023, 11:31 PM

	F10786575: D13551.id33128.diff
	May 26 2023, 8:39 AM

	F10786451: D13551.id33131.diff
	May 26 2023, 8:07 AM

View All 13 Files

Subscribers

silke

Staudey

Tokens

"Like" token, awarded by silke.

Details

Reviewers

Staudey

Group Reviewers

Triage Team

Commits

R2816:fbc7af82090b: element: Remove electron override

Summary

Upstream updated their version of Electron, so there's no need to override the version during the build anymore.

Test Plan

Connected to existing rooms, sent a few messages

Diff Detail

Repository

R2816 element

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4346
Build 4346: arc lint + arc unit

Event Timeline

ReillyBrogan created this revision.Sep 6 2022, 3:49 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 6 2022, 3:49 PM

ReillyBrogan requested review of this revision.Sep 6 2022, 3:49 PM

Harbormaster completed remote builds in B4346: Diff 33128.Sep 6 2022, 3:49 PM

CC @silke

See https://github.com/vector-im/element-desktop/pull/403/files

silke awarded a token.Sep 6 2022, 5:44 PM

Cheers! I was about to check in the next release if that workaround was still necessary ?

This revision is now accepted and ready to land.Sep 7 2022, 8:47 AM

Closed by commit R2816:fbc7af82090b: element: Remove electron override (authored by ReillyBrogan, committed by Staudey). · Explain WhySep 7 2022, 8:47 AM

This revision was automatically updated to reflect the committed changes.

Staudey added a commit: R2816:fbc7af82090b: element: Remove electron override.

Revision Contents
Changeset List

Path

Size

1190 lines

1 line

10 lines

6 lines

12 lines

Diff 33128

View Options

abi_symbols

View Options

abi_used_libs

View Options

abi_used_symbols

View Options

package.yml

View Options

element: Remove electron overrideClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33128

abi_symbols

abi_used_libs

abi_used_symbols

package.yml

pspec_x86_64.xml

element: Remove electron override
ClosedPublic
Actions

Revision Contents
Changeset List