Page MenuHomeSolus

Update speex and speexdsp to 1.2.1
ClosedPublic

Authored by aleksvor on Aug 24 2022, 11:12 AM.

Details

Summary

Changelog:

  • Speex:
    • wav_io: check for EOF when seeking in wav (fixes hang discovered by fuzzing).
    • fixed-point: make left shift macros use unsigned to avoid undefined behaviour.
    • math_approx: use unsigned int for LCG pseudorandom generator (avoids integer overflow).
    • speexenc: guard against invalid channel numbers.
    • speexdec: make left shift macros use unsigned to avoid undefined behaviour.
    • autotools: do not use deprecated macros.
  • SpeexDSP:
    • fixed-point: Remove unused MULT16_32_Q1[1-4] macros and inlines.
    • fixed-point: don't truncate 32-bit arg to MULT16_32_Q15.
    • fixed-point resample: remove 1-bit shift right before interpolation.
    • fixed-point: introduce MULT16_32_32 to handle unexpected types in MULT16_32_Q15.
    • Fix incorrect macro names in arch.h.
    • Remove unused stack_alloc.h.
    • autotools: do not use deprecated macros.
Test Plan

Encoded speex audio using ffmpeg with libspeex encoder, played it in VLC.

Diff Detail

Repository
R1859 libspeex
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Aug 24 2022, 11:12 AM
aleksvor requested review of this revision.Aug 24 2022, 11:12 AM
algent accepted this revision.Aug 25 2022, 5:26 PM
algent added a subscriber: algent.

LGTM, thanks!

This revision is now accepted and ready to land.Aug 25 2022, 5:26 PM
This revision was automatically updated to reflect the committed changes.