Page MenuHomeSolus

Initial inclusion of GCstar
ClosedPublic

Authored by palto42 on Aug 18 2022, 6:33 PM.

Details

Summary

GCstar is an application for management of collections (films, music, games, books, etc...).

Resolves T10130

Signed-off-by: Matthias Homann <palto@mailbox.org>

Test Plan
  • Built and installed locally
  • Added new books to existing library
  • Updated library entries

Diff Detail

Repository
R5586 gcstar
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

palto42 created this revision.Aug 18 2022, 6:33 PM
palto42 requested review of this revision.Aug 18 2022, 6:33 PM
palto42 updated this revision to Diff 32982.Aug 18 2022, 6:46 PM

removed obsolete info.md

Girtablulu requested changes to this revision.Aug 27 2022, 7:28 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
7

? can this be removed?

This revision now requires changes to proceed.Aug 27 2022, 7:28 PM
palto42 updated this revision to Diff 33073.Aug 28 2022, 9:03 AM

removed comment as requested by @Girtablulu

palto42 marked an inline comment as done.Aug 28 2022, 9:04 AM

Removed commendt line as requested.

algent requested changes to this revision.Aug 28 2022, 9:24 AM
algent added a subscriber: algent.

Did you manually do the package.yml file? You need to fix indentation of lines, instead of two it shoud be four.
For example, from this:

rundeps:
  - libwww-perl
  - perl-datetime-format-strptime

to this:

rundeps:
    - libwww-perl
    - perl-datetime-format-strptime

But do this for all lines.

This revision now requires changes to proceed.Aug 28 2022, 9:24 AM
palto42 updated this revision to Diff 33084.Aug 28 2022, 10:15 AM

adjusted indentation to 4 spaces

Hi @algent, the 2 space indentation was the default setting of the "Prettier" formatted in VScode. Changed it to 4 spaces now.

algent accepted this revision.Aug 28 2022, 10:17 AM

LGTM, thanks!

Hi @algent, the 2 space indentation was the default setting of the "Prettier" formatted in VScode. Changed it to 4 spaces now.

If you do a make bump locally you will notice that package.yml will change to it defaults, and then just fix the release number to 1.

Hi @algent

If you do a make bump locally you will notice that package.yml will change to it defaults, and then just fix the release number to 1.

Thanks for this hint & accepting my request.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2022, 6:21 PM
Closed by commit R5586:c20be5eee776: Initial inclusion of GCstar (authored by palto42, committed by algent). · Explain Why
This revision was automatically updated to reflect the committed changes.