Page MenuHomeSolus

Initial inclusion of GCstar
ClosedPublic

Authored by palto42 on Aug 18 2022, 6:33 PM.
Tags
None
Referenced Files
F11014182: D13484.id33073.diff
Fri, Aug 4, 9:22 PM
F11004764: D13484.diff
Tue, Aug 1, 3:18 AM
F10886972: D13484.diff
Jun 26 2023, 5:19 AM
F10886959: D13484.diff
Jun 26 2023, 5:04 AM
F10884892: D13484.id.diff
Jun 25 2023, 4:14 AM
F10869435: D13484.diff
Jun 18 2023, 4:05 AM
F10845336: D13484.id32981.diff
Jun 10 2023, 11:53 PM
F10845125: D13484.id33088.diff
Jun 10 2023, 11:08 PM
Subscribers

Details

Summary

GCstar is an application for management of collections (films, music, games, books, etc...).

Resolves T10130

Signed-off-by: Matthias Homann <palto@mailbox.org>

Test Plan
  • Built and installed locally
  • Added new books to existing library
  • Updated library entries

Diff Detail

Repository
R5586 gcstar
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
7

? can this be removed?

This revision now requires changes to proceed.Aug 27 2022, 7:28 PM

Removed commendt line as requested.

algent requested changes to this revision.Aug 28 2022, 9:24 AM
algent added a subscriber: algent.

Did you manually do the package.yml file? You need to fix indentation of lines, instead of two it shoud be four.
For example, from this:

rundeps:
  - libwww-perl
  - perl-datetime-format-strptime

to this:

rundeps:
    - libwww-perl
    - perl-datetime-format-strptime

But do this for all lines.

This revision now requires changes to proceed.Aug 28 2022, 9:24 AM

adjusted indentation to 4 spaces

Hi @algent, the 2 space indentation was the default setting of the "Prettier" formatted in VScode. Changed it to 4 spaces now.

Hi @algent, the 2 space indentation was the default setting of the "Prettier" formatted in VScode. Changed it to 4 spaces now.

If you do a make bump locally you will notice that package.yml will change to it defaults, and then just fix the release number to 1.

Hi @algent

If you do a make bump locally you will notice that package.yml will change to it defaults, and then just fix the release number to 1.

Thanks for this hint & accepting my request.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2022, 6:21 PM
Closed by commit R5586:c20be5eee776: Initial inclusion of GCstar (authored by palto42, committed by algent). · Explain Why
This revision was automatically updated to reflect the committed changes.