Page MenuHomeSolus

Update network-manager to 1.10.0
ClosedPublic

Authored by der_eismann on Nov 12 2017, 11:10 AM.
Tags
None
Referenced Files
F10978958: D1348.id3347.diff
Sat, Jul 22, 9:34 PM
F10978955: D1348.id3346.diff
Sat, Jul 22, 9:34 PM
F10978953: D1348.id3345.diff
Sat, Jul 22, 9:34 PM
F10978952: D1348.id3308.diff
Sat, Jul 22, 9:34 PM
F10978951: D1348.id.diff
Sat, Jul 22, 9:34 PM
F10971530: D1348.diff
Fri, Jul 21, 7:49 AM
F10922017: D1348.id3345.diff
Sun, Jul 9, 4:13 PM
F10918709: D1348.id3346.diff
Jul 8 2023, 11:11 PM

Details

Summary

Update network-manager to 1.10.0. Full changelog can be found here.

Test Plan

Connected to different networks via LAN/WiFi, connected to VPNs, reconnected after standby... working fine.

However such a critical component should be tested more thoroughly.

Diff Detail

Repository
R2155 network-manager
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

der_eismann edited the test plan for this revision. (Show Details)

Also curious of the inclusion of xz-32bit and glib2-32bit

Are they needed for building (I know some of the core doesn't do dependencies which would hurt the 32bit parts not in the solbuild image), but naturally we don't want to enable the -devels

package.yml
21

Should be able to remove: (a 32bit devel will always depend on 64bit devel)

pkgconfig(libndp)
pkgconfig(libnl-3.0)
pkgconfig(nss)

Also curious of the inclusion of xz-32bit and glib2-32bit

/usr/bin/ld: warning: liblzma.so.5, needed by /usr/lib32/libsystemd.so.0, not found (try using -rpath or -rpath-link)
But I changed it to pkgconfig32(liblzma), missed that somehow.
It was successfully building without glib2 now, I don't remember the reason for including it anymore.

der_eismann marked an inline comment as done.

Update packager info

LGTM, it's Monday, so plenty of time for testing

This revision is now accepted and ready to land.Nov 13 2017, 12:33 PM
This revision was automatically updated to reflect the committed changes.

@der_eismann please fix your git config

Author: Your Name <you@example.com>
Date: Mon Nov 13 23:33:29 2017 +1100

Any more commits like this won't be accepted

In D1348#21598, @ikey wrote:

@der_eismann please fix your git config

Author: Your Name <you@example.com>
Date: Mon Nov 13 23:33:29 2017 +1100

Any more commits like this won't be accepted

Was fixed already in this commit:

Update packager info

Maybe I (or we) can create a script to setup a solbuild-environment, forgot it after the 4th time.

Packager info != git info. You need to make sure your git config is well, configured.

You're right, still - happened for the first time and won't happen again, see D1349 and D1350. I'm sorry.

Shit happens - its nothing to be sorry about, we just adapt and move on :D

@der_eismann We still know who submitted it from the username and packager info so that's what really matters. To this day I sometimes screw up after my streamed packaging sessions where I'd forget to change my packager file back to normal :D

Well then it's good not to be alone :D