Page MenuHomeSolus

initial inclusion of hnterm
ClosedPublic

Authored by nazar on Aug 16 2022, 5:21 PM.

Details

Reviewers
algent
Group Reviewers
Triage Team
Maniphest Tasks
T10129: hnterm
Commits
R5577:032a3365a761: initial inclusion of hnterm
Summary

resolves T10129

Test Plan

display news.ycombinator.com front-page; switch to Ask HN; open submission and browse comments

Diff Detail

Repository
R5577 hnterm
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nazar created this revision.Aug 16 2022, 5:21 PM
nazar requested review of this revision.Aug 16 2022, 5:21 PM
algent requested changes to this revision.Aug 16 2022, 5:45 PM
algent added a subscriber: algent.
algent added inline comments.
package.yml
7

MIT

8

network.news

11

Browse Hacker News interactively in your terminal.

13

git after pkgconfigs

14

not needed, part of system.devel

21

You can simplify this to -Dm00755

This revision now requires changes to proceed.Aug 16 2022, 5:45 PM

You can add also homepage : https://hnterm.ggerganov.com/

nazar updated this revision to Diff 32942.Aug 16 2022, 6:03 PM

fix license and component; add homepage

nazar updated this revision to Diff 32943.Aug 16 2022, 6:07 PM

not needed pkgconfig(ncursesw)

algent requested changes to this revision.Aug 16 2022, 6:10 PM

@nazar. package.yml looks fine for me. You have to rebuild it again to update the pspec_x86_64.xml file.

This revision now requires changes to proceed.Aug 16 2022, 6:10 PM
nazar edited the test plan for this revision. (Show Details)Aug 16 2022, 6:11 PM
nazar updated this revision to Diff 32944.Aug 16 2022, 6:15 PM

rebuild

algent accepted this revision.Aug 17 2022, 5:08 PM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 17 2022, 5:08 PM
This revision was automatically updated to reflect the committed changes.