Page MenuHomeSolus

element: Fix Wayland app icon
ClosedPublic

Authored by ReillyBrogan on Aug 8 2022, 6:47 PM.

Details

Summary

Fix the desktop file so that windows are correctly associated when running in Wayland session.

Note: You may have to unpin the Element icon from your panel and then pin it again for it to work correctly after this update

Test Plan

Started in X11 and Wayland session and confirmed that windows were correctly associated by the DE

Diff Detail

Repository
R2816 element
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ReillyBrogan created this revision.Aug 8 2022, 6:47 PM
ReillyBrogan requested review of this revision.Aug 8 2022, 6:47 PM

In Wayland the window app_id needs to match the name of the desktop file in order for windows to be correctly associated. This fixes Plasma (and presumably GNOME too) so that the Element icon is shown in the top left of the title bar and directly underneath the window in the overview.

silke added a comment.Aug 8 2022, 7:39 PM

Looks good! Note that this causes Element in the Budgie Icon Task List to somewhat break: it does start Element, but under a different icon. Nothing major, you just have to unpin and pin it again.

Looks good! Note that this causes Element in the Budgie Icon Task List to somewhat break: it does start Element, but under a different icon. Nothing major, you just have to unpin and pin it again.

Yes, that's always the downside of moving a desktop file like this. Existing "pins" break and need to be un-pinned and then re-pinned.

Staudey accepted this revision.Aug 9 2022, 6:09 PM
Staudey edited the summary of this revision. (Show Details)
Staudey edited the test plan for this revision. (Show Details)
Staudey added a subscriber: Staudey.

LGTM, thanks!

This revision is now accepted and ready to land.Aug 9 2022, 6:09 PM
This revision was automatically updated to reflect the committed changes.