bitwarden-desktop: Update Electron and use Wayland for Wayland users
ClosedPublic
Actions

Authored by ReillyBrogan on Jul 28 2022, 7:20 PM.

Details

Reviewers

Girtablulu

Group Reviewers

Triage Team

Commits

R5536:4b8c20af9d4d: bitwarden-desktop: Update Electron and use Wayland for Wayland users

Summary

Electron 19.0.10 added the --ozone-platform-hint=auto flag which causes Electron to automatically use Wayland if the user is currently in a Wayland session

Test Plan

Launched, logged in, checked a few password entries
Checked that it launched natively as a Wayland app in a Wayland session and under X in an X11 session

Diff Detail

Repository

R5536 bitwarden-desktop

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4142
Build 4142: arc lint + arc unit

Event Timeline

ReillyBrogan created this revision.Jul 28 2022, 7:20 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 28 2022, 7:20 PM

ReillyBrogan requested review of this revision.Jul 28 2022, 7:20 PM

Harbormaster completed remote builds in B4142: Diff 32786.Jul 28 2022, 7:20 PM

Hmm, fails with FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory for me. Maybe I just can't build this on my PC (don't seem to run out of memory though)

Girtablulu accepted this revision.Aug 1 2022, 2:25 PM

This revision is now accepted and ready to land.Aug 1 2022, 2:25 PM

Closed by commit R5536:4b8c20af9d4d: bitwarden-desktop: Update Electron and use Wayland for Wayland users (authored by ReillyBrogan, committed by Girtablulu). · Explain WhyAug 1 2022, 2:26 PM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R5536:4b8c20af9d4d: bitwarden-desktop: Update Electron and use Wayland for Wayland users.