Page MenuHomeSolus

update to 1.9.5, add symlink for bin/vagrant
ClosedPublic

Authored by mcritchlow on May 18 2017, 3:52 PM.
Tags
None
Referenced Files
F11066809: D133.id241.diff
Fri, Aug 11, 6:44 PM
F11066808: D133.id.diff
Fri, Aug 11, 6:44 PM
F11066807: D133.id529.diff
Fri, Aug 11, 6:44 PM
F11066806: D133.id481.diff
Fri, Aug 11, 6:44 PM
F11066805: D133.id480.diff
Fri, Aug 11, 6:44 PM
F11066804: D133.id482.diff
Fri, Aug 11, 6:44 PM
F11066803: D133.id478.diff
Fri, Aug 11, 6:44 PM
F11066802: D133.id477.diff
Fri, Aug 11, 6:44 PM
Subscribers

Details

Summary
  • update vagrant to 1.9.5
  • replace bin/vagrant installation with a symlink. Current package is broken for at least some features. This is because
  • the bin/vagrant script has some relative requirements that break via the current installation. This can be confirmed
  • by installing and running vagrant --version.
Test Plan

Installed locally and on a VM. Confirmed that vagrant --version and vagrant init work as expected.

Diff Detail

Repository
R3106 vagrant
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Concerned about the ABI removals. Is it checking for xslt during configure time, is ours too old and thus it's disabling it, did they drop functionality that would've used it, etc.

Concerned about the ABI removals. Is it checking for xslt during configure time, is ours too old and thus it's disabling it, did they drop functionality that would've used it, etc.

Yeah I suspect it might be the relaxed/removed dependency on nokogiri. But I'll take another look at the make output and follow up. Thanks for the feedback!

@JoshStrobl - So yeah, I believe this is the result of https://github.com/mitchellh/vagrant/pull/8571

I've attached the log from running make on my end as well.

Sorry for the delayed response, finally weeding through a bunch of patches.

Could you add a test plan for vagrant please? Can do so by following the steps at https://solus-project.com/articles/packaging/submitting-a-package/en/#updating-task-information

Thanks!

This revision now requires changes to proceed.May 26 2017, 1:36 PM
mcritchlow edited edge metadata.

Replaced current bin/vagrant installation with symlink. Added test plan. Cleaned up Description.

mcritchlow retitled this revision from update to 1.9.5 to update to 1.9.5, add symlink for bin/vagrant.
mcritchlow edited the summary of this revision. (Show Details)
mcritchlow edited the test plan for this revision. (Show Details)

test plan and updates seem to have gotten lost. Adding again.

removing NOKOGIRI export line, because confusing developers is mean

removing libxslt dependency, no longer required

@JoshStrobl - I think this is good to go now, assuming you approve.

Yea sorry for the delay. LGTM.

This revision is now accepted and ready to land.May 29 2017, 11:19 AM
This revision was automatically updated to reflect the committed changes.