Page MenuHomeSolus
Differential D13356

polkit: Update to v121
ClosedPublic
Actions

Authored by ReillyBrogan on Jul 16 2022, 11:44 PM.
Tags
None
Referenced Files
F11004248: D13356.diff
Mon, Jul 31, 11:56 PM
F10987438: D13356.diff
Mon, Jul 24, 5:38 AM
F10883979: D13356.id32676.diff
Jun 24 2023, 5:32 PM
F10883651: D13356.id32732.diff
Jun 24 2023, 12:25 PM
F10863987: D13356.diff
Jun 17 2023, 5:23 AM
F10845978: D13356.id32676.diff
Jun 11 2023, 3:13 AM
F10844005: D13356.id32670.diff
Jun 10 2023, 7:51 PM
F10841968: D13356.id32732.diff
Jun 10 2023, 9:39 AM
View All 25 Files
Subscribers
DataDrake
Jacek
joebonrichie
Tokens
"Burninate" token, awarded by Jacek.

Details

Reviewers
joebonrichie
Group Reviewers
Triage Team
Commits
R2462:7cb4b521241f: polkit: Update to v121
Summary

Changelog

Additional Changes

  • Switched from Solus' fork of polkit (polkit-noscript) back to upstream due to non-maintenance of polkit-noscript.

Depends on D13355
Part of T10321

Test Plan
  • Tested in meta-task

Diff Detail

Repository
R2462 polkit
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ReillyBrogan created this revision.Jul 16 2022, 11:44 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptJul 16 2022, 11:44 PM
ReillyBrogan requested review of this revision.Jul 16 2022, 11:44 PM
Harbormaster completed remote builds in B4075: Diff 32670.Jul 16 2022, 11:44 PM
ReillyBrogan planned changes to this revision.Jul 16 2022, 11:45 PM

Just removing from the review queue

ReillyBrogan edited the summary of this revision. (Show Details)Jul 16 2022, 11:47 PM
ReillyBrogan added a comment.Jul 16 2022, 11:55 PM

The following packages that provide keyrules are almost certainly broken in some way by this change:

  • blueman
  • budgie-control-center
  • corectrl
  • flatpak (!!!!)
  • gnome-control-center
  • gvfs (!!!!)
  • libvirt (gnome-boxes, virt-manager etc)
  • udisks (!!!!)

bolt might be broken. It provides a .rules file but not a .keyrules file

ReillyBrogan updated this revision to Diff 32671.Jul 17 2022, 12:12 AM
  • Tests actually do work now that the duktape/libm issue is fixed
Harbormaster completed remote builds in B4076: Diff 32671.Jul 17 2022, 12:12 AM
ReillyBrogan planned changes to this revision.Jul 17 2022, 12:15 AM
DataDrake requested changes to this revision.Jul 17 2022, 12:18 AM
DataDrake added a subscriber: DataDrake.

Keyrules/no-script is used in a bunch of our stuff. We need those changes from Ikey's branch. It's why this hasn't been updated yet.

Jacek added a subscriber: Jacek.Jul 17 2022, 7:36 AM
Jacek awarded a token.Jul 17 2022, 7:44 AM
joebonrichie added a subscriber: joebonrichie.Jul 17 2022, 8:45 AM

May as well backport this patch to make it stateless as well since we're here: https://gitlab.freedesktop.org/polkit/polkit/-/commit/b6538f6e9cc956959494aff0eeade3a0b5733103

ReillyBrogan updated this revision to Diff 32676.Jul 17 2022, 9:43 AM
  • Stateless initial rules file
Harbormaster completed remote builds in B4081: Diff 32676.Jul 17 2022, 9:43 AM
ReillyBrogan added a comment.Jul 17 2022, 9:44 AM
In D13356#228727, @joebonrichie wrote:

May as well backport this patch to make it stateless as well since we're here: https://gitlab.freedesktop.org/polkit/polkit/-/commit/b6538f6e9cc956959494aff0eeade3a0b5733103

Done.

ReillyBrogan added a child revision: D13361: corectrl: Update to 1.2.4 and adapt to Polkit changes.Jul 18 2022, 2:59 AM
ReillyBrogan added a child revision: D13362: blueman: Update to v2.3.1 and adapt to Polkit changes.Jul 18 2022, 3:04 AM
ReillyBrogan added a child revision: D13363: bolt: Update to v0.9.2 and adapt to Polkit changes.Jul 18 2022, 3:06 AM
ReillyBrogan added a child revision: D13364: flatpak: Adapt to Polkit changes.Jul 18 2022, 3:09 AM
ReillyBrogan added a child revision: D13365: libvirt: Adapt to Polkit changes.Jul 18 2022, 3:11 AM
ReillyBrogan added a child revision: D13366: os-installer: Adapt to Polkit changes.Jul 18 2022, 3:14 AM
ReillyBrogan added a child revision: D13367: udisks: Adapt to Polkit changes.Jul 18 2022, 3:16 AM
ReillyBrogan added a comment.Jul 18 2022, 3:20 AM

I'm waiting on the GNOME stack update to be complete before I can push diffs for budgie-control-center, gnome-control-center, and gvfs.

ReillyBrogan added a child revision: D13370: budgie-control-center: Adapt to Polkit changes.Jul 21 2022, 3:33 PM
ReillyBrogan updated this revision to Diff 32706.Jul 21 2022, 3:41 PM
  • re-order comments
Harbormaster completed remote builds in B4097: Diff 32706.Jul 21 2022, 3:41 PM
ReillyBrogan added a child revision: D13371: gvfs: Adapt to Polkit changes.Jul 21 2022, 4:47 PM
ReillyBrogan added a child revision: D13372: gnome-control-center: Adapt to Polkit changes.Jul 21 2022, 5:01 PM
ReillyBrogan edited the summary of this revision. (Show Details)Jul 21 2022, 5:55 PM
joebonrichie added a comment.Jul 24 2022, 9:58 AM

Changelog

Additional Changes

  • Switched from Solus' fork of polkit (polkit-noscript) back to upstream due to non-maintenance of polkit-noscript.
joebonrichie added a comment.Jul 24 2022, 10:00 AM

This has been fairly well tested at this point, can you also update the test plan reflecting meta task.

ReillyBrogan updated this revision to Diff 32725.Jul 24 2022, 3:44 PM
  • Update commit message
Harbormaster completed remote builds in B4111: Diff 32725.Jul 24 2022, 3:45 PM
ReillyBrogan edited the summary of this revision. (Show Details)Jul 24 2022, 3:45 PM
ReillyBrogan edited the test plan for this revision. (Show Details)
joebonrichie accepted this revision.Jul 25 2022, 9:33 AM
joebonrichie removed a reviewer: DataDrake.
This revision is now accepted and ready to land.Jul 25 2022, 9:33 AM
Closed by commit R2462:7cb4b521241f: polkit: Update to v121 (authored by ReillyBrogan, committed by joebonrichie). · Explain WhyJul 25 2022, 9:38 AM
This revision was automatically updated to reflect the committed changes.
joebonrichie added a commit: R2462:7cb4b521241f: polkit: Update to v121.

Revision Contents
Changeset List

Diff 32732

View Options

abi_libs

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_symbols

Loading...
View Options

files/0001-install-50-default-rules-in-usr.patch

Loading...
View Options

files/0003-data-Use-modern-stateless-dbus-system.d-directory.patch

Loading...
View Options

files/in-systemd-we-trust.patch

Loading...
View Options

files/polkit.tmpfiles

Loading...
View Options

files/security/CVE-2018-1116.patch

Loading...
View Options

files/security/CVE-2018-19788.patch

Loading...
View Options

files/security/CVE-2019-6133.patch

Loading...
View Options

files/security/CVE-2021-3560.patch

Loading...
View Options

files/security/CVE-2021-4034.patch

Loading...
View Options

files/series

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.