Page MenuHomeSolus

edk2-ovmf: Fix TPM support
ClosedPublic

Authored by ReillyBrogan on Jun 29 2022, 6:52 AM.

Details

Summary
  • ovmf 202202 renmaed the TPM_ENABLE build flag for enabling TPM1/2 support in the firmware to TPM1_ENABLE and TPM2_ENABLE (for TPM v1 and TPM v2 respectively). If the new flags were not used TPM support was not enabled in the firmware which would break VMs that had a software/passthrough TPM.
Test Plan
  • Booted Win 11 VM and confirmed that TPM was working.

Diff Detail

Repository
R4211 edk2-ovmf
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ReillyBrogan created this revision.Jun 29 2022, 6:52 AM
ReillyBrogan requested review of this revision.Jun 29 2022, 6:52 AM

Thanks for the fix. I'll take care of that after the libicu rebuilds are done. While I did notice an issue with swtpm on my system, that I subsequently fixed, I didn't realize that TPM support was broken in a different way. ^^

Staudey accepted this revision.Jun 30 2022, 4:40 PM

LGTM, thanks again!

This revision is now accepted and ready to land.Jun 30 2022, 4:40 PM
This revision was automatically updated to reflect the committed changes.