Package Update: Update OTPClient to 2.5.1
ClosedPublic
Actions

Authored by moriel5 on Jun 27 2022, 8:07 PM.

Details

Reviewers

Staudey

Group Reviewers

Triage Team

Maniphest Tasks

T10303: Update OTPClient to 2.5.1

Commits

R4982:358449c3acf3: Package Update: Update OTPClient to 2.5.1

Summary

This release fixes a small cosmetic issue (markup is now enabled on change database dialog)

Changes from 2.5:

NEW: rows can now be reordered. Enable the reordering mode by using the "up down" arrows button on the top left, then drag and drop rows where you want
NEW: added a dark theme (enable it settings)
NEW: allow to switch database. This is useful if you have multiple OTPClient databases (e.g. work, personal, etc)
NEW: add a button to lock the app
FIX: when app is locked, the content is now hidden
FIX: when clicking cancel on decryption, you can now choose to select another database
FIX: small code improvements

Fixes T10303

Signed-off-by: Moriel Yitzhak Ever <emoriel17@yahoo.com>

Test Plan

Launch OTPClient and verify that password lock functions properly.
Select desired OTP lines and verify that their values indeed allow me to log in to Solus Phabricator.
Press button for new reorganization mode, and reorganize the lines.

Diff Detail

Repository

R4982 OTPClient

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

moriel5 created this revision.Jun 27 2022, 8:07 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 27 2022, 8:07 PM

moriel5 requested review of this revision.Jun 27 2022, 8:07 PM

Harbormaster completed remote builds in B4018: Diff 32570.Jun 27 2022, 8:07 PM

moriel5 mentioned this in T10303: Update OTPClient to 2.5.1.Jun 27 2022, 8:08 PM

Two small-ish things:

Seems like you didn't include the changes to abi_symbols, abi_used_symbols and pspec_x86_64.xml in your commit/diff.
Your changelog and summary seem to be cut off at the right side for some lines ^^

This revision now requires changes to proceed.Jun 27 2022, 8:21 PM

In D13324#227986, @Staudey wrote:

Two small-ish things:

Seems like you didn't include the changes to abi_symbols, abi_used_symbols and pspec_x86_64.xml in your commit/diff.

Your changelog and summary seem to be cut off at the right side for some lines ^^

That is odd, I believe I had a similar issue the first time I had updated FlashROM, I'll take a look at what fixed that back then.
I really have absolutely no idea what could be causing this, as I had literally copy-pasted the changelog line-by-line.

Simply git add * (to add all the files, make sure to make clean first to get rid of the .eopkg files, if they're still there); git commit --amend and then arc diff --update D13324 to update the differential
Have you pasted them out of some editor that didn't show the whole lines? ?

Thanks, I'll do so immediately.
No, I first copied them over from Firefox, but then realized that I was in the Git commit, so then copied... That must have been the issue, me copying the lines from Nano (to GEdit, and then back).

Due to me forgetting how to use Git, the accompanying files were missing, that has been fixed now.
Also, the lines were cut off, because I copied them over from and back to nano without realizing the ramifications, so I recopied the lines.

Harbormaster completed remote builds in B4019: Diff 32571.Jun 27 2022, 8:43 PM

Staudey edited the summary of this revision. (Show Details)Jun 27 2022, 8:47 PM

Staudey added a task: T10303: Update OTPClient to 2.5.1.

Staudey edited the summary of this revision. (Show Details)

Thanks, I didn't realize that the differential itself did not get updated (and I have no idea why not) with the new commit.

Hmm, I was about to accept this diff after you updated it, but then I noticed that the other changed files are still not included. Did you also do a git commit --amend? (I edited my previous comment shortly after I posted it, because I'd accidentally left out this step; maybe you saw it before that)

Two small notes:

I just noticed that you also created a task for updating this software. If you're going to submit a patch/diff that is not necessary, you can simply submit it without a corresponding task. But if there is a task, add something like "Fixes TXXXX" in the Summary. I've done that now for you after I discovered the task.
You have to either manually change the summary on phab (it doesn't apply the changes from the commit after the initial submission) or use arc diff --edit. I forgot to mention that ^^ In this case I've also simply edited the summary on phab to spare you the trouble of another back and forth ?

This revision is now accepted and ready to land.Jun 27 2022, 8:55 PM

Staudey requested changes to this revision.Jun 27 2022, 8:55 PM

This revision now requires changes to proceed.Jun 27 2022, 8:55 PM

I believe I did, but just in case I didn't, I'll do so again.

It appears that I really do need to build the package after adhering to proper packaging habits, not before with a standalone package.yml. That has been fixed now.

Harbormaster completed remote builds in B4020: Diff 32572.Jun 27 2022, 9:06 PM