Page MenuHomeSolus

Remove LAPACK from openblas
AcceptedPublic

Authored by GZGavinZhao on Tue, Jun 21, 10:18 PM.

Details

Reviewers
Girtablulu
Group Reviewers
Triage Team
Summary

Complete disable LAPACK from openblas as it is incomplete. Use the lapack package if it is needed.

Test Plan

Ran numpy without issues.

lapack rebuilds in progress...

Signed-off-by: Gavin Zhao <git@gzgz.dev>

Diff Detail

Repository
R2228 openblas
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3987
Build 3987: arc lint + arc unit

Event Timeline

GZGavinZhao created this revision.Tue, Jun 21, 10:18 PM
GZGavinZhao requested review of this revision.Tue, Jun 21, 10:18 PM

Bump version number.

I'm not sure how to proceed with R1601. It was disabled because there was a file conflict, but that is now resolved with this commit.

I wanted to create a diff to R1601 but I'm unable to pull it.

See T10209.

I'm not sure how to proceed with R1601. It was disabled because there was a file conflict, but that is now resolved with this commit.
I wanted to create a diff to R1601 but I'm unable to pull it.
See T10209.

Okay, I have re-activated the lapack repository (R1601) for you, so you can now pull from it and submit a diff.

Note that we'll also have to undeprecate it in the solus-sc data: https://github.com/getsolus/solus-sc/blob/master/repo_data/distribution.xml.in#L104

Also things like gretl seem to rely on the OpenBLAS lapack support, if I'm reading it correctly

https://dev.getsol.us/source/gretl/

Beep-Boop! Gavin's dependency bot would like to inform you that according to symbol removal from abi_symbols, the following packages need to be rebuilt:

  • Package suitesparse needs rebuilding!
  • Package gretl needs rebuilding!
  • Package jags needs rebuilding!
  • Package ceres-solver needs rebuilding!
  • Package gromacs needs rebuilding!
  • Package pytorch needs rebuilding!
  • Package scipy needs rebuilding!
  • Package python2-numpy needs rebuilding!
  • Package octave needs rebuilding!
  • Package opencv needs rebuilding!
  • Package arpack needs rebuilding!
  • Package numpy needs rebuilding!
  • Package qrupdate needs rebuilding!

Also julia and suitesparce seem to use openblas for lapack support (at least it seems that way looking at the package.yml)

Maybe a task to track this wouldn't hurt.

Good catch. Thanks!

Girtablulu accepted this revision.Sat, Jun 25, 12:19 PM
Girtablulu added a subscriber: Girtablulu.

LGTM

This revision is now accepted and ready to land.Sat, Jun 25, 12:19 PM