Differential D13293

Update thermald to 2.4.9
ClosedPublic
Actions

Authored by davidjharder on Sun, Jun 19, 5:21 PM.

Details

Reviewers

Staudey

Group Reviewers

Triage Team

Maniphest Tasks

T10108: Update thermald to latest version

Commits

R3033:499739a5738b: Update thermald to 2.4.9

Summary

Summarized Changelog

2.4.9

Fix performance issues for Dell Latitude 5421
Fix performance issues for Dell Latitude 7320/7420
Adaptive improvements
Static analysis fixes
Fix test for compressed data vaults

2.4.8

Fix Ideapad thermal shutdown issue

2.4.7

Fix AC/DC power limit issue in some HP Tiger Lake systems
Regression fix for RAPL MSR usage in xml config file
Added Jasper Lake and Alder Lake CPU models
Debug scripts for log collection to upload

2.4.6

No relevant changes

2.4.5

Address low performance with Dell Latitude 5420 with the latest BIOS

Full changelog can be viewed below build instructions here

Resolves T10108

Test Plan

Run on Dell XPS, see that daemon is happy with sudo thermald --no-daemon --loglevel=debug

Diff Detail

Repository

R3033 thermald

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

davidjharder created this revision.Sun, Jun 19, 5:21 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSun, Jun 19, 5:21 PM

davidjharder requested review of this revision.Sun, Jun 19, 5:21 PM

Harbormaster completed remote builds in B3980: Diff 32512.Sun, Jun 19, 5:21 PM

davidjharder edited the summary of this revision. (Show Details)Sun, Jun 19, 5:22 PM

davidjharder edited the summary of this revision. (Show Details)

Staudey requested changes to this revision.Mon, Jun 20, 12:47 PM

Staudey added a subscriber: Staudey.

Staudey added inline comments.

package.yml
7	Are you sure about that? To me it looks like all or most source files are GPL 2 or later e.g. https://github.com/intel/thermal_daemon/blob/master/src/thd_cdev.cpp#L8

This revision now requires changes to proceed.Mon, Jun 20, 12:47 PM

Good point. I searched for "or later", and found nothing, when I should have searched for "any later"

Leave license alone

Harbormaster completed remote builds in B3985: Diff 32522.Mon, Jun 20, 1:04 PM

LGTM now, thanks!

This revision is now accepted and ready to land.Mon, Jun 20, 1:09 PM

Closed by commit R3033:499739a5738b: Update thermald to 2.4.9 (authored by davidjharder, committed by Staudey). · Explain WhyMon, Jun 20, 1:09 PM

This revision was automatically updated to reflect the committed changes.

Staudey added a commit: R3033:499739a5738b: Update thermald to 2.4.9.

Revision Contents
Changeset List

		Path
A	M	abi_libs (1 line)
A	M	abi_symbols (472 lines)
M		abi_used_libs (2 lines)
M		abi_used_symbols (38 lines)
M		package.yml (7 lines)
M		pspec_x86_64.xml (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32512	666b973		Sun, Jun 19, 5:21 PM	★	★
Diff 2	32522	666b973	Leave licencse alone	Mon, Jun 20, 1:04 PM	★	★
Diff 3	32523	666b973	R3033:499739a5738bf8be7817ef877ef4e875d5fe99fb	Mon, Jun 20, 1:09 PM	★	★