Page MenuHomeSolus

Initial commit of webp-pixbuf-loader
ClosedPublic

Authored by Phantop on Jun 12 2022, 5:53 PM.
Tags
None
Referenced Files
F11007071: D13280.diff
Tue, Aug 1, 6:20 PM
F10998370: D13280.diff
Thu, Jul 27, 9:48 PM
F10897468: D13280.diff
Jul 2 2023, 7:12 AM
F10897455: D13280.id32499.diff
Jul 2 2023, 7:09 AM
F10897448: D13280.id.diff
Jul 2 2023, 7:06 AM
F10868506: D13280.diff
Jun 17 2023, 11:54 PM
F10794085: D13280.id32499.diff
May 27 2023, 2:30 PM
F10793660: D13280.id32474.diff
May 27 2023, 12:32 PM
Tokens
"Love" token, awarded by Staudey.

Details

Summary

Adds in a loader for WebP files for GdkPixBuf-based image viewers.

Test Plan

Install package and open a WebP file with Viewnior.

Diff Detail

Repository
R5570 webp-pixbuf-loader
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Girtablulu added a subscriber: Girtablulu.

Task request or is it needed for another software in our repo?

This revision now requires changes to proceed.Jun 16 2022, 12:35 PM

Task request or is it needed for another software in our repo?

It's a little unclear what the process is for submitting a package that hasn't already been requested, but I argue this is needed for GdkPixbuf-based image viewers to use WebP files.

This also would resolve T8793, which was marked as Wontfix due to libwebp not including this.

Any update on the possibility of this being accepted?

a usysconf trigger should be added to update the gdk-pixbuf cache after install
/usr/bin/gdk-pixbuf-query-loaders --update-cache

Successfully tested with eom

package.yml
12

build deps should be sorted alphabetically

a usysconf trigger should be added to update the gdk-pixbuf cache after install
/usr/bin/gdk-pixbuf-query-loaders --update-cache

Should I simply add that command after the install section or is there a specific way to do this? I wasn't able to find any info on this in the packaging documentation.

Should I simply add that command after the install section or is there a specific way to do this? I wasn't able to find any info on this in the packaging documentation.

Sorry, just saw that you haven't receive an answer to this. What @kyrios123 meant is that we should add a new trigger to usysconf itself, which will allow it to detect changes to pixbuf loaders and update the gdk-pixbuf cache after package installations

Sorry, just saw that you haven't receive an answer to this. What @kyrios123 meant is that we should add a new trigger to usysconf itself, which will allow it to detect changes to pixbuf loaders and update the gdk-pixbuf cache after package installations

I've made a pull request on that repo to add this. You can find it here.

Sort dependencies alphabetically in package.yml

Phantop marked an inline comment as done.

Update webp-pixbuf-loader to 0.0.6

This revision is now accepted and ready to land.Jul 25 2022, 4:46 PM
This revision was automatically updated to reflect the committed changes.