Changelog available here.
Details
Details
- Reviewers
joebonrichie Girtablulu - Group Reviewers
Triage Team
Telegram still works. xxhsum works as well.
Packager notes:
- Removed the dispatch feature. We let the loader do the work.
Diff Detail
Diff Detail
- Repository
- R4345 xxhash
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 3890 Build 3890: arc lint + arc unit
Event Timeline
Comment Actions
I think the dispatch is only for the binaries as they don't link to their own libraries. Would we need full phat performance in the xxhsum binaries themselves?
Comment Actions
Not sure I'm following you.
I think the dispatch is only for the binaries as they don't link to their own libraries.
You mean stuff that uses dlopen?
Would we need full phat performance in the xxhsum binaries themselves?
IDK. I'd rather have a more predictable approach by loading the appropriate .so file via the linker.
This comment was removed by joebonrichie.
Comment Actions
e.g.
$ ldd /usr/bin/xxhsum linux-vdso.so.1 (0x00007ffea27db000) libc.so.6 => /usr/lib/haswell/libc.so.6 (0x00007f3ec9414000) /usr/lib64/ld-linux-x86-64.so.2 (0x00007f3ec9672000)
xxhsum doesn't link against libxxhash.so so wouldn't see the benefits from the haswell libs, which is why i enabled the dispatch originally, e.g. if you run xxhsum -b with this patch the performance is a lot lower.
I asking do we need the fastest performance in xxhsum binaries themselves ?