Page MenuHomeSolus

Bootstrap crystal 1.4.1
ClosedPublic

Authored by biqqles on May 17 2022, 7:02 PM.

Details

Reviewers
Girtablulu
Group Reviewers
Triage Team
Maniphest Tasks
T2215: crystal
Commits
R4308:7e908d8e7367: Bootstrap crystal 1.4.1
Summary

R4308 was lucky enough to have been created 4 years ago, but has languished barren.

A previous attempt at bootstrapping was D1093. The task is much easier now, with no patching required.

The interpreter can be enabled when we update to v1.5.0 which will include a fix for an issue caused by glibc 2.34.

Resolves T2215.

Test Plan

All specs pass. Also tested crystal eval and compiling a simple .cr file.

Diff Detail

Repository
R4308 crystal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

biqqles created this revision.May 17 2022, 7:02 PM
biqqles requested review of this revision.May 17 2022, 7:02 PM

FTR, the error is

$ crystal eval ""
Showing last frame. Use --error-trace for full trace.

In /usr/lib64/crystal/exception/call_stack/libunwind.cr:1:1

 1 | require "c/dlfcn"
     ^
Error: can't find file 'c/dlfcn'

This is confusing because /usr/lib64/crystal/lib_c/x86_64-solus-linux exists, but the compiler is not using it for some reason.

algent edited the summary of this revision. (Show Details)May 17 2022, 8:29 PM
algent added a task: T2215: crystal.

Think I have fixed it by setting CRYSTAL_CONFIG_TARGET. Currently building, which takes a long time even when setting threads, which I'm not confident actually does anything.

biqqles updated this revision to Diff 32333.May 17 2022, 9:55 PM

Set target

biqqles edited the summary of this revision. (Show Details)May 17 2022, 9:57 PM
biqqles edited the test plan for this revision. (Show Details)
biqqles updated this revision to Diff 32466.Sat, Jun 11, 9:47 PM

Disable interpreter

Waiting for v1.5.0 to be released with a fix for https://github.com/crystal-lang/crystal/issues/12036 before re-enabling interpreter.

biqqles edited the summary of this revision. (Show Details)Sat, Jun 11, 10:49 PM
biqqles retitled this revision from [WIP] Bootstrap crystal 1.4.1 to Bootstrap crystal 1.4.1.Mon, Jun 13, 5:50 PM
biqqles edited the summary of this revision. (Show Details)
biqqles edited the test plan for this revision. (Show Details)
biqqles set the repository for this revision to R4308 crystal.
biqqles updated this revision to Diff 32484.Mon, Jun 13, 5:56 PM

Get tests running

biqqles updated this revision to Diff 32489.Wed, Jun 15, 12:08 AM

Ready for review

Girtablulu requested changes to this revision.Thu, Jun 16, 12:29 PM
Girtablulu added a subscriber: Girtablulu.

the rest looks good

package.yml
15

some of them can a pkgconfig be used

pspec_x86_64.xml
554

can you remove this?

659

we don't support arm

694

same

This revision now requires changes to proceed.Thu, Jun 16, 12:29 PM

The files for those platforms are used for cross-compilation.

biqqles updated this revision to Diff 32498.Thu, Jun 16, 5:56 PM

Use pkgconfig and add maintainers

algent added a subscriber: algent.Fri, Jun 17, 8:44 PM
This comment was removed by algent.
This revision is now accepted and ready to land.Sat, Jun 25, 12:16 PM
This revision was automatically updated to reflect the committed changes.