Paths

Table of Contentst

Differential D13220

Bootstrap crystal 1.4.1
ClosedPublic
Actions

Authored by biqqles on May 17 2022, 7:02 PM.

Tags

None

Referenced Files

	F10799806: D13220.id32484.diff
	Sun, May 28, 4:21 PM

	F10799417: D13220.id32466.diff
	Sun, May 28, 2:48 PM

	F10799358: D13220.id32333.diff
	Sun, May 28, 2:29 PM

	F10799339: D13220.id32332.diff
	Sun, May 28, 2:21 PM

	F10799034: D13220.id32555.diff
	Sun, May 28, 12:30 PM

	F10799018: D13220.id32489.diff
	Sun, May 28, 12:26 PM

	F10798991: D13220.id32498.diff
	Sun, May 28, 12:15 PM

	F10798271: D13220.diff
	Sun, May 28, 8:46 AM

View All 18 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

Commits

R4308:7e908d8e7367: Bootstrap crystal 1.4.1

Summary

R4308 was lucky enough to have been created 4 years ago, but has languished barren.

A previous attempt at bootstrapping was D1093. The task is much easier now, with no patching required.

The interpreter can be enabled when we update to v1.5.0 which will include a fix for an issue caused by glibc 2.34.

Resolves T2215.

Test Plan

All specs pass. Also tested crystal eval and compiling a simple .cr file.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

biqqles created this revision.May 17 2022, 7:02 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 17 2022, 7:02 PM

Harbormaster completed remote builds in B3880: Diff 32332.May 17 2022, 7:02 PM

biqqles requested review of this revision.May 17 2022, 7:02 PM

FTR, the error is

$ crystal eval ""
Showing last frame. Use --error-trace for full trace.

In /usr/lib64/crystal/exception/call_stack/libunwind.cr:1:1

 1 | require "c/dlfcn"
     ^
Error: can't find file 'c/dlfcn'

This is confusing because /usr/lib64/crystal/lib_c/x86_64-solus-linux exists, but the compiler is not using it for some reason.

algent edited the summary of this revision. (Show Details)May 17 2022, 8:29 PM

algent added a task: T2215: crystal.

Think I have fixed it by setting CRYSTAL_CONFIG_TARGET. Currently building, which takes a long time even when setting threads, which I'm not confident actually does anything.

Set target

Harbormaster completed remote builds in B3881: Diff 32333.May 17 2022, 9:55 PM

biqqles edited the summary of this revision. (Show Details)May 17 2022, 9:57 PM

biqqles edited the test plan for this revision. (Show Details)

Disable interpreter

Harbormaster completed remote builds in B3951: Diff 32466.Jun 11 2022, 9:47 PM

Waiting for v1.5.0 to be released with a fix for https://github.com/crystal-lang/crystal/issues/12036 before re-enabling interpreter.

biqqles edited the summary of this revision. (Show Details)Jun 11 2022, 10:49 PM

biqqles retitled this revision from [WIP] Bootstrap crystal 1.4.1 to Bootstrap crystal 1.4.1.Jun 13 2022, 5:50 PM

biqqles edited the summary of this revision. (Show Details)

biqqles edited the test plan for this revision. (Show Details)

biqqles set the repository for this revision to R4308 crystal.

Get tests running

Harbormaster completed remote builds in B3964: Diff 32484.Jun 13 2022, 5:56 PM

Ready for review

Harbormaster completed remote builds in B3968: Diff 32489.Jun 15 2022, 12:08 AM

the rest looks good

package.yml
15	some of them can a pkgconfig be used
pspec_x86_64.xml
554	can you remove this?
659	we don't support arm
694	same

This revision now requires changes to proceed.Jun 16 2022, 12:29 PM

The files for those platforms are used for cross-compilation.

Use pkgconfig and add maintainers

Harbormaster completed remote builds in B3971: Diff 32498.Jun 16 2022, 5:57 PM

algent added a subscriber: algent.Jun 17 2022, 8:44 PM

This comment was removed by algent.

LGTM

This revision is now accepted and ready to land.Jun 25 2022, 12:16 PM

Closed by commit R4308:7e908d8e7367: Bootstrap crystal 1.4.1 (authored by biqqles, committed by Girtablulu). · Explain WhyJun 25 2022, 12:17 PM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R4308:7e908d8e7367: Bootstrap crystal 1.4.1.

Revision Contents
Changeset List

Path

Size

5 lines

1 line

1 line

611 lines

8 lines

abi_used_symbols

483 lines

44 lines

pspec_x86_64.xml

1361 lines

Diff 32555

MAINTAINERS.md

Loading...

Makefile

Loading...

abi_libs

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...