Page MenuHomeSolus

Bootstrap crystal 1.4.1

Authored by biqqles on May 17 2022, 7:02 PM.
Referenced Files
F10799806: D13220.id32484.diff
Sun, May 28, 4:21 PM
F10799417: D13220.id32466.diff
Sun, May 28, 2:48 PM
F10799358: D13220.id32333.diff
Sun, May 28, 2:29 PM
F10799339: D13220.id32332.diff
Sun, May 28, 2:21 PM
F10799034: D13220.id32555.diff
Sun, May 28, 12:30 PM
F10799018: D13220.id32489.diff
Sun, May 28, 12:26 PM
F10798991: D13220.id32498.diff
Sun, May 28, 12:15 PM
F10798271: D13220.diff
Sun, May 28, 8:46 AM


Group Reviewers
Triage Team
Maniphest Tasks
T2215: crystal
R4308:7e908d8e7367: Bootstrap crystal 1.4.1

R4308 was lucky enough to have been created 4 years ago, but has languished barren.

A previous attempt at bootstrapping was D1093. The task is much easier now, with no patching required.

The interpreter can be enabled when we update to v1.5.0 which will include a fix for an issue caused by glibc 2.34.

Resolves T2215.

Test Plan

All specs pass. Also tested crystal eval and compiling a simple .cr file.

Diff Detail

R4308 crystal
Lint Not Applicable
Tests Not Applicable

Event Timeline

FTR, the error is

$ crystal eval ""
Showing last frame. Use --error-trace for full trace.

In /usr/lib64/crystal/exception/call_stack/

 1 | require "c/dlfcn"
Error: can't find file 'c/dlfcn'

This is confusing because /usr/lib64/crystal/lib_c/x86_64-solus-linux exists, but the compiler is not using it for some reason.

Think I have fixed it by setting CRYSTAL_CONFIG_TARGET. Currently building, which takes a long time even when setting threads, which I'm not confident actually does anything.

biqqles edited the test plan for this revision. (Show Details)

Waiting for v1.5.0 to be released with a fix for before re-enabling interpreter.

biqqles retitled this revision from [WIP] Bootstrap crystal 1.4.1 to Bootstrap crystal 1.4.1.Jun 13 2022, 5:50 PM
biqqles edited the summary of this revision. (Show Details)
biqqles edited the test plan for this revision. (Show Details)
biqqles set the repository for this revision to R4308 crystal.
Girtablulu added a subscriber: Girtablulu.

the rest looks good


some of them can a pkgconfig be used


can you remove this?


we don't support arm



This revision now requires changes to proceed.Jun 16 2022, 12:29 PM

The files for those platforms are used for cross-compilation.

Use pkgconfig and add maintainers

This comment was removed by algent.
This revision is now accepted and ready to land.Jun 25 2022, 12:16 PM
This revision was automatically updated to reflect the committed changes.