Page MenuHomeSolus

Update starship to 1.6.3
ClosedPublic

Authored by Phantop on May 10 2022, 1:31 PM.
Tags
None
Referenced Files
F10885730: D13212.id.diff
Jun 25 2023, 2:30 PM
F10804508: D13212.id32305.diff
May 29 2023, 4:26 PM
F10803799: D13212.id32302.diff
May 29 2023, 1:29 PM
F10803785: D13212.id32303.diff
May 29 2023, 1:25 PM
F10803326: D13212.id32304.diff
May 29 2023, 11:16 AM
F10803118: D13212.id32301.diff
May 29 2023, 10:17 AM
F10801853: D13212.diff
May 29 2023, 4:17 AM
F10795631: D13212.id32303.diff
May 27 2023, 9:58 PM
Subscribers

Details

Summary

Changelogs

Resolves T10257

Test Plan

Set starship as prompt, launch shell, and open a git repo

Diff Detail

Repository
R5113 starship
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Staudey requested changes to this revision.May 10 2022, 2:53 PM
Staudey added a subscriber: Staudey.

Wow, that was quick ? (looking at the homepage I first thought this was only the task requesting an update, that I got a notification for)

One thing though: Since starship was rebuilt once during the glibc update this patch is not based on the latest commit. Can you rebase on master and update this diff? Thanks!

This revision now requires changes to proceed.May 10 2022, 2:53 PM

Wow, that was quick ? (looking at the homepage I first thought this was only the task requesting an update, that I got a notification for)

Yeah, Rust programs like this tend to be like that a lot. I think ever since I first submitted the package all I've been doing it running yupdate with changing version numbers.

One thing though: Since starship was rebuilt once during the glibc update this patch is not based on the latest commit. Can you rebase on master and update this diff? Thanks!

Whoops I managed to do this for two package updates I tried submitting today. Luckily it's very easy to fix that.

Whoops I managed to do this for two package updates I tried submitting today. Luckily it's very easy to fix that.

It happens to the best of us ^^

package.yml
6

One last thing (I hope): You've now accidentally removed the homepage link that algent included when he rebuilt for glibc. Can you please add it back again, so we don't lose information? Thanks!

Perfect, thank you!
Looks good to me now (I'll just take the small liberty of re-adding the homepage to the pspec_x86_64.xml too before committing this, to spare us another back and forth [and since I built it already, and thus have the updated xml available])

This revision is now accepted and ready to land.May 10 2022, 3:24 PM
This revision was automatically updated to reflect the committed changes.