Page MenuHomeSolus

Update starship to 1.6.3
ClosedPublic

Authored by Phantop on Tue, May 10, 1:31 PM.

Details

Summary

Changelogs

Resolves T10257

Test Plan

Set starship as prompt, launch shell, and open a git repo

Diff Detail

Repository
R5113 starship
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Phantop created this revision.Tue, May 10, 1:31 PM
Phantop requested review of this revision.Tue, May 10, 1:31 PM
Phantop edited the summary of this revision. (Show Details)Tue, May 10, 1:33 PM
Phantop edited the summary of this revision. (Show Details)Tue, May 10, 2:11 PM
Staudey requested changes to this revision.Tue, May 10, 2:53 PM
Staudey added a subscriber: Staudey.

Wow, that was quick ๐Ÿ˜† (looking at the homepage I first thought this was only the task requesting an update, that I got a notification for)

One thing though: Since starship was rebuilt once during the glibc update this patch is not based on the latest commit. Can you rebase on master and update this diff? Thanks!

This revision now requires changes to proceed.Tue, May 10, 2:53 PM
Phantop updated this revision to Diff 32302.Tue, May 10, 2:56 PM

Rebase to master

Phantop added a comment.EditedTue, May 10, 3:00 PM

Wow, that was quick ๐Ÿ˜† (looking at the homepage I first thought this was only the task requesting an update, that I got a notification for)

Yeah, Rust programs like this tend to be like that a lot. I think ever since I first submitted the package all I've been doing it running yupdate with changing version numbers.

One thing though: Since starship was rebuilt once during the glibc update this patch is not based on the latest commit. Can you rebase on master and update this diff? Thanks!

Whoops I managed to do this for two package updates I tried submitting today. Luckily it's very easy to fix that.

Phantop updated this revision to Diff 32303.Tue, May 10, 3:00 PM

Fix the version number

Whoops I managed to do this for two package updates I tried submitting today. Luckily it's very easy to fix that.

It happens to the best of us ^^

package.yml
6

One last thing (I hope): You've now accidentally removed the homepage link that algent included when he rebuilt for glibc. Can you please add it back again, so we don't lose information? Thanks!

Phantop updated this revision to Diff 32304.Tue, May 10, 3:10 PM

Readd homepage

Staudey accepted this revision.Tue, May 10, 3:24 PM

Perfect, thank you!
Looks good to me now (I'll just take the small liberty of re-adding the homepage to the pspec_x86_64.xml too before committing this, to spare us another back and forth [and since I built it already, and thus have the updated xml available])

This revision is now accepted and ready to land.Tue, May 10, 3:24 PM
This revision was automatically updated to reflect the committed changes.