Does this build in Openjdk-17?

In D13210#225897, @oly wrote:

Update commit message and add link to changelog.

Thanks! Unfortunately it's still not quite where I want it yet. Two points/nitpicks:

1. Please don't put the changelog in the first line/heading of the summary but a line below it, and use something like in the form of Changelog available [here](link-to-changelog) instead of simply dropping in the link. While you're at it, please also replace the link with "https://github.com/babashka/babashka/blob/v0.8.2/CHANGELOG.md" so it's tagged to this specific version and won't change when somebody looks at it later (not the worst thing in the world, but as I said, while you're at it ? )
2. Please also update the contents of this diff here on phabricator (see that it still says "Inclusion..." and so on)

(and Reilly's suggestion is also a good point; might as well update it to the new JDK version, if possible)

In D13210#225940, @Staudey wrote:

In D13210#225897, @oly wrote:

Update commit message and add link to changelog.

Thanks! Unfortunately it's still not quite where I want it yet. Two points/nitpicks:

1. Please don't put the changelog in the first line/heading of the summary but a line below it, and use something like in the form of Changelog available [here](link-to-changelog) instead of simply dropping in the link. While you're at it, please also replace the link with "https://github.com/babashka/babashka/blob/v0.8.2/CHANGELOG.md" so it's tagged to this specific version and won't change when somebody looks at it later (not the worst thing in the world, but as I said, while you're at it ? )
2. Please also update the contents of this diff here on phabricator (see that it still says "Inclusion..." and so on)

(and Reilly's suggestion is also a good point; might as well update it to the new JDK version, if possible)

Updated to use java 17 and adjusted commit partially.

Yeah no problem I always get in a mess with arc diff, how can I change the message so it does not say Initial inclusion of Babashka resolves it does not show in the git log so I guess there is a arc command to change it ?

In D13210#225962, @oly wrote:

how can I change the message so it does not say Initial inclusion of Babashka resolves it does not show in the git log so I guess there is a arc command to change it ?

You can do it with the "Edit revision" button in the top right

You can do it with the "Edit revision" button in the top right

Okay thanks that's easier, hopefully that's everything addressed

Are you sure that you're actually using openjdk-17 for the build? The JAVA_CMD variable is still pointing to openjdk-11 (it appears that openjdk-11 is a rundep of leiningen so it's still getting pulled in)

In D13210#225968, @ReillyBrogan wrote:

Are you sure that you're actually using openjdk-17 for the build? The JAVA_CMD variable is still pointing to openjdk-11 (it appears that openjdk-11 is a rundep of leiningen so it's still getting pulled in)

Good spot your quite right I will change rebuild and test again and upload probably tomorrow now.

I would recommend to update graalvm too, and then build babashka against it.

Yeah, seems like it still builds against openjdk-11, despite the JAVA_CMD env, most likely due to graalvm being built with openjdk-11 (a special bundled version).

I will take a look at graal usually take longer as my personal laptop does not have the ram to build it. saying that I did read they improved the usage in the newer version so maybe i will get lucky :)

It looks like Graal does support being built to be compatible with JDK 17 level features