@Jacek replace Relies on with Depends on to make rocm stack.

edit: Well you can ignore this now :D

Can you update the test plan? Either with an application or you could consider converting this cuda sample to hip for example https://github.com/ROCm-Developer-Tools/HIP/tree/develop/samples/0_Intro/square

In D13172#228658, @joebonrichie wrote:

Can you update the test plan? Either with an application or you could consider converting this cuda sample to hip for example https://github.com/ROCm-Developer-Tools/HIP/tree/develop/samples/0_Intro/square

I managed to build rocBLAS, which is a complex package, that builds a separate kernel for each supported GPU architecture, the whole build took 2 hours. For now I don't have time to test anything else, I am leaving for a week. Best test would be to test Blender if it works with HIP, once it gets updated to 3.2.
If you think it is not enough testing, could you accept the entire rest of ROCm for OpenCL support, and -HIP could wait? But I would love if -HIP got into the repo, nothing suggests it is in any way broken, and packages could be build against it when needed.

Not yet included in repo - waiting on rocm-opencl.

Also pushed this now that there are no more blockers.

Unfortunately fails on the server (and locally for me) now: https://build.getsol.us//logs/rocm-hip-5.1.3-1.log.gz

It currently builds fine locally for me.

I vaguely remember when I packaged ROCm for my personal repo I had to switch the build order around and/or added some dependencies, but I forgot which...

@Staudey Maybe cleaning the cache and rebuilding could work? I tried several times, both building against Unstable and also my personal repo, and all succeeded. However, I do get a very long pause around the line that broke:

-- Found HIP: /home/build/YPKG/root/rocm-hip/build/hipamd-rocm-5.1.3/build (found version "5.1.0") 
-- Performing Test HIP_CLANG_SUPPORTS_PARALLEL_JOBS
-- Performing Test HIP_CLANG_SUPPORTS_PARALLEL_JOBS - Failed
-- host interface - found
-- HIP runtime lib type - shared
-- CMAKE_TESTING_TOOL: 
-- CMAKE HIP ARCHITECTURES: OFF
-- ROCm Agent Enumurator Result: 0
-- Using offload arch string:   --offload-arch=gfx1032
# Pauses for almost a minute!

FileNotFoundError: [Errno 2] No such file or directory: '/sys/class/kfd/kfd/topology/nodes/' does this path only exist if you have AMD hardware installed?

Specific failing line: https://github.com/ROCm-Developer-Tools/HIP/blob/rocm-5.2.1/tests/hit/HIT.cmake#L49

Most likely failing as cmake has been updated since this was initially landed.

Fixed in R5565:2f155faf6450. Needs some testing.

@joebonrichie @GZGavinZhao You guys are amazing! Thank you so much for fixing it so quickly, while I was sleeping ;) And yes, rocm-opencl works just fine, and I can build rocBLAS with rocm-hip, so this seems to be working just fine too. Thanks for your amazing job!