Page MenuHomeSolus

[RFC] Initial commit of rocm-opencl for T6614
AcceptedPublic

Authored by Jacek on Apr 23 2022, 8:36 PM.

Details

Reviewers
Girtablulu
Group Reviewers
Triage Team
Summary

For T6614
Depends on D13162 D13163 D13166
This package still needs a ton of work and testing

Test Plan

rocm-clinfo segfaults for me, need to find where it is misconfigured

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3874
Build 3874: arc lint + arc unit

Event Timeline

Jacek created this revision.Apr 23 2022, 8:36 PM
Jacek requested review of this revision.Apr 23 2022, 8:36 PM
Jacek added a comment.Apr 23 2022, 8:56 PM

I don't quite understand how to configure

-DROCM_PATH=%prefix%
-DCMAKE_PREFIX_PATH="%workdir%/ROCclr-rocm-%version%;%prefix%"
-DAMD_OPENCL_PATH="%workdir%/ROCm-OpenCL-Runtime-rocm-%version%"

If I should configure them to the build directories or the install directories. Could someone more experienced take a look and suggest something?

Jacek updated this revision to Diff 32183.Apr 25 2022, 12:28 AM

Ready for review, now only need help with testing

Jacek retitled this revision from WIP of rocm-opencl for T6614 to [RFC] Initial commit of rocm-opencl for T6614.Apr 25 2022, 12:37 AM
Jacek edited the summary of this revision. (Show Details)Apr 25 2022, 12:41 AM
Jacek updated this revision to Diff 32186.Apr 25 2022, 1:20 AM

Add patch that enables support for Polaris architecture

Jacek updated this revision to Diff 32192.Apr 25 2022, 11:13 AM

Install librocclr that was previously ommited

Jacek updated this revision to Diff 32194.Apr 25 2022, 5:50 PM

Remove unnecessary installs

Girtablulu requested changes to this revision.Wed, Apr 27, 9:39 AM
Girtablulu added a subscriber: Girtablulu.

for what do you need the ls commands?

package.yml
16

pkgconfig?

20

pkgconfig?

52

why not using pushd/popd?

66

install -Dm00644

74

same as above

78

same as above

This revision now requires changes to proceed.Wed, Apr 27, 9:39 AM
Jacek updated this revision to Diff 32216.Wed, Apr 27, 12:13 PM

Add MAINTAINERS.md, remove unnecessary lses and switch to pushd and popd

Jacek updated this revision to Diff 32219.Wed, Apr 27, 1:04 PM

Fix one cmake argument that caused a very long path in the resulting package and arrange builddeps in alphabetical order

joebonrichie added inline comments.
pspec_x86_64.xml
23

move this to /usr/share/OpenCL/vendors/amdocl64.icd to match intel-compute-runtime and for statelessness.

Jacek updated this revision to Diff 32220.Wed, Apr 27, 1:55 PM

Move amdocl64.icd to to match intel-compute-runtime and for statelessness.

Jacek updated this revision to Diff 32256.Wed, May 4, 4:55 PM

Build it with patched solbuild, now that I can use it

Jacek updated this revision to Diff 32319.Sat, May 14, 12:23 PM

Split into -opencl and -rocclr, allow for standalone build of rocclr for simpler build of -hip

Jacek updated this revision to Diff 32322.Sat, May 14, 1:55 PM

Add rocm-compilersupport as rundep

Girtablulu accepted this revision.Sun, May 22, 1:39 PM
This revision is now accepted and ready to land.Sun, May 22, 1:39 PM