Details

Reviewers

Girtablulu

Group Reviewers

Triage Team

Summary

For T6614
Depends on D13162 D13163 D13166
This package still needs a ton of work and testing

Test Plan

rocm-clinfo segfaults for me, need to find where it is misconfigured

Diff Detail

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3874
Build 3874: arc lint + arc unit

Event Timeline

Jacek created this revision.Apr 23 2022, 8:36 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptApr 23 2022, 8:36 PM

Jacek requested review of this revision.Apr 23 2022, 8:36 PM

Harbormaster completed remote builds in B3772: Diff 32170.Apr 23 2022, 8:36 PM

I don't quite understand how to configure

-DROCM_PATH=%prefix%
-DCMAKE_PREFIX_PATH="%workdir%/ROCclr-rocm-%version%;%prefix%"
-DAMD_OPENCL_PATH="%workdir%/ROCm-OpenCL-Runtime-rocm-%version%"

If I should configure them to the build directories or the install directories. Could someone more experienced take a look and suggest something?

Ready for review, now only need help with testing

Harbormaster completed remote builds in B3783: Diff 32183.Apr 25 2022, 12:28 AM

Jacek retitled this revision from WIP of rocm-opencl for T6614 to [RFC] Initial commit of rocm-opencl for T6614.Apr 25 2022, 12:37 AM

Jacek edited the summary of this revision. (Show Details)Apr 25 2022, 12:41 AM

Add patch that enables support for Polaris architecture

Harbormaster completed remote builds in B3786: Diff 32186.Apr 25 2022, 1:20 AM

Install librocclr that was previously ommited

Harbormaster completed remote builds in B3792: Diff 32192.Apr 25 2022, 11:13 AM

Remove unnecessary installs

Harbormaster completed remote builds in B3794: Diff 32194.Apr 25 2022, 5:50 PM

for what do you need the ls commands?

package.yml
16	pkgconfig?
20	pkgconfig?
52	why not using pushd/popd?
66	install -Dm00644
74	same as above
78	same as above

This revision now requires changes to proceed.Wed, Apr 27, 9:39 AM

Jacek edited the summary of this revision. (Show Details)Wed, Apr 27, 11:09 AM

Jacek added a parent revision: D13166: [RFC] Initial commit of rocm-runtime for T6614.

algent edited the summary of this revision. (Show Details)Wed, Apr 27, 11:42 AM

algent added parent revisions: D13162: [RFC] Initial commit of rocm-compilersupport for T6614, D13163: [RFC] Initial commit of rocm-cmake for T6614.

algent added a child revision: D13172: [RFC] Initial commit of rocm-hip for T6614.

Add MAINTAINERS.md, remove unnecessary lses and switch to pushd and popd

Harbormaster completed remote builds in B3805: Diff 32216.Wed, Apr 27, 12:13 PM

Fix one cmake argument that caused a very long path in the resulting package and arrange builddeps in alphabetical order

Harbormaster completed remote builds in B3808: Diff 32219.Wed, Apr 27, 1:05 PM

joebonrichie added a subscriber: joebonrichie.Wed, Apr 27, 1:47 PM

joebonrichie added inline comments.

pspec_x86_64.xml
23	move this to /usr/share/OpenCL/vendors/amdocl64.icd to match intel-compute-runtime and for statelessness.

Move amdocl64.icd to to match intel-compute-runtime and for statelessness.

Harbormaster completed remote builds in B3809: Diff 32220.Wed, Apr 27, 1:55 PM

Build it with patched solbuild, now that I can use it

Harbormaster completed remote builds in B3831: Diff 32256.Wed, May 4, 4:55 PM

Split into -opencl and -rocclr, allow for standalone build of rocclr for simpler build of -hip

Harbormaster completed remote builds in B3872: Diff 32319.Sat, May 14, 12:23 PM

Add rocm-compilersupport as rundep

Harbormaster completed remote builds in B3874: Diff 32322.Sat, May 14, 1:55 PM

Girtablulu accepted this revision.Sun, May 22, 1:39 PM

This revision is now accepted and ready to land.Sun, May 22, 1:39 PM

@Girtablulu Before this can be built, https://github.com/getsolus/ypkg/pull/29 and https://github.com/getsolus/solbuild/pull/22 need to be accepted.

		Path
A	M	MAINTAINERS.md (5 lines)
A	M	Makefile (1 line)
A	M	abi_libs (3 lines)
A	M	abi_symbols (1319 lines)
A	M	abi_used_libs (8 lines)
A	M	abi_used_symbols (374 lines)
A	M	files/0001-Allow-ROCclr-to-be-built-standalone.patch (202 lines)
A	M	files/0001-SWDEV-321118-Use-GNUInstallDirs.patch (126 lines)
A	M	files/0001-SWDEV-323669-Fix-linux-arch-detection.patch (53 lines)
A	M	files/0001-enable-gfx800.patch (16 lines)
A	M	files/0002-SWDEV-321116-Allow-disabling-ICD-loader.patch (168 lines)
A	M	files/0003-SWDEV-321116-Drop-unnecessary-ICD-include.patch (44 lines)
A	M	files/series (3 lines)
A	M	package.yml (100 lines)
A	M	pspec_x86_64.xml (214 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32170	4b825dc		Apr 23 2022, 8:36 PM	★	★
Diff 2	32183	4b825dc	Ready for review, now only need help with testing	Apr 25 2022, 12:28 AM	★	★
Diff 3	32186	4b825dc	Add patch that enables support for Polaris architecture	Apr 25 2022, 1:20 AM	★	★
Diff 4	32192	4b825dc	Install librocclr that was previously ommited	Apr 25 2022, 11:13 AM	★	★
Diff 5	32194	4b825dc	Remove unnecessary `install`s	Apr 25 2022, 5:50 PM	★	★
Diff 6	32216	4b825dc	Add MAINTAINERS.md, remove unnecessary `ls`es and switch to pushd and popd	Wed, Apr 27, 12:13 PM	★	★
Diff 7	32219	4b825dc	Fix one cmake argument that caused a very long path in the resulting package…	Wed, Apr 27, 1:04 PM	★	★
Diff 8	32220	4b825dc	Move `amdocl64.icd` to to match intel-compute-runtime and for statelessness.	Wed, Apr 27, 1:55 PM	★	★
Diff 9	32256	4b825dc	Build it with patched solbuild, now that I can use it	Wed, May 4, 4:55 PM	★	★
Diff 10	32319	4b825dc	Split into -opencl and -rocclr, allow for standalone build of rocclr for…	Sat, May 14, 12:23 PM	★	★
Diff 11	32322	4b825dc	Add rocm-compilersupport as rundep	Sat, May 14, 1:55 PM	★	★

Status	Author	Revision
Accepted	Jacek	D13167 [RFC] Initial commit of rocminfo for T6614
Accepted	Jacek	D13172 [RFC] Initial commit of rocm-hip for T6614
Accepted	Jacek	D13168 [RFC] Initial commit of rocm-opencl for T6614
Accepted	Jacek	D13166 [RFC] Initial commit of rocm-runtime for T6614
Accepted	Jacek	D13164 [RFC] Initial commit of hsakmt for T6614
Accepted	Jacek	D13165 [RFC] Initial commit of numactl for T6614
Accepted	Jacek	D13162 [RFC] Initial commit of rocm-compilersupport for T6614
Accepted	Jacek	D13161 [RFC] Initial commit of rocm-device-libs for T6614
Needs Review	Jacek	D13163 [RFC] Initial commit of rocm-cmake for T6614

[RFC] Initial commit of rocm-opencl for T6614
AcceptedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 32322

MAINTAINERS.md

Makefile

abi_libs

abi_symbols

abi_used_libs

abi_used_symbols

files/0001-Allow-ROCclr-to-be-built-standalone.patch

files/0001-SWDEV-321118-Use-GNUInstallDirs.patch

files/0001-SWDEV-323669-Fix-linux-arch-detection.patch

files/0001-enable-gfx800.patch

files/0002-SWDEV-321116-Allow-disabling-ICD-loader.patch

files/0003-SWDEV-321116-Drop-unnecessary-ICD-include.patch

files/series

package.yml

pspec_x86_64.xml

[RFC] Initial commit of rocm-opencl for T6614AcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32322

MAINTAINERS.md

Makefile

abi_libs

abi_symbols

abi_used_libs

abi_used_symbols

files/0001-Allow-ROCclr-to-be-built-standalone.patch

files/0001-SWDEV-321118-Use-GNUInstallDirs.patch

files/0001-SWDEV-323669-Fix-linux-arch-detection.patch

files/0001-enable-gfx800.patch

files/0002-SWDEV-321116-Allow-disabling-ICD-loader.patch

files/0003-SWDEV-321116-Drop-unnecessary-ICD-include.patch

files/series

package.yml

pspec_x86_64.xml

[RFC] Initial commit of rocm-opencl for T6614
AcceptedPublic
Actions

Revision Contents
Changeset List