Page MenuHomeSolus

Initial commit of rocm-opencl for T6614
ClosedPublic

Authored by Jacek on Apr 23 2022, 8:36 PM.
Tags
None
Referenced Files
F11018987: D13168.id32194.diff
Sun, Aug 6, 4:35 PM
F11018533: D13168.id32183.diff
Sun, Aug 6, 12:57 PM
F11007830: D13168.diff
Tue, Aug 1, 10:21 PM
F10997613: D13168.id.diff
Thu, Jul 27, 10:57 AM
F10997358: D13168.id32581.diff
Thu, Jul 27, 6:54 AM
F10972474: D13168.id32373.diff
Fri, Jul 21, 1:41 PM
F10947888: D13168.id32256.diff
Sat, Jul 15, 6:00 PM
F10946484: D13168.id32186.diff
Sat, Jul 15, 10:21 AM

Details

Summary

For T6614
Depends on D13162 D13163 D13166

Test Plan

Confirmed it is working on Vega iGPU and Polaris

Diff Detail

Repository
R5564 rocm-opencl
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Jacek requested review of this revision.Apr 23 2022, 8:36 PM

I don't quite understand how to configure

-DROCM_PATH=%prefix%
-DCMAKE_PREFIX_PATH="%workdir%/ROCclr-rocm-%version%;%prefix%"
-DAMD_OPENCL_PATH="%workdir%/ROCm-OpenCL-Runtime-rocm-%version%"

If I should configure them to the build directories or the install directories. Could someone more experienced take a look and suggest something?

Ready for review, now only need help with testing

Jacek retitled this revision from WIP of rocm-opencl for T6614 to [RFC] Initial commit of rocm-opencl for T6614.Apr 25 2022, 12:37 AM

Add patch that enables support for Polaris architecture

Install librocclr that was previously ommited

Remove unnecessary installs

Girtablulu added a subscriber: Girtablulu.

for what do you need the ls commands?

package.yml
16

pkgconfig?

20

pkgconfig?

52

why not using pushd/popd?

66

install -Dm00644

74

same as above

78

same as above

This revision now requires changes to proceed.Apr 27 2022, 9:39 AM

Add MAINTAINERS.md, remove unnecessary lses and switch to pushd and popd

Fix one cmake argument that caused a very long path in the resulting package and arrange builddeps in alphabetical order

joebonrichie added inline comments.
pspec_x86_64.xml
23

move this to /usr/share/OpenCL/vendors/amdocl64.icd to match intel-compute-runtime and for statelessness.

Move amdocl64.icd to to match intel-compute-runtime and for statelessness.

Build it with patched solbuild, now that I can use it

Split into -opencl and -rocclr, allow for standalone build of rocclr for simpler build of -hip

Add rocm-compilersupport as rundep

This revision is now accepted and ready to land.May 22 2022, 1:39 PM

Add numactl as builddep, one more patch, and one more argument to fix a warning

Remove the patches allowing to split rocclr into separate package
Unfortunately it means that the hip build will have to contain all the sources of -opencl, and all the patches, but standalone build was abandoned by AMD employee maintaining for Fedora, so better roll back too.

Remove specifying for which architectures to build, seems to not be necessary

Can you update the test plan? People have confirmed it working now AFAIK

Jacek edited the test plan for this revision. (Show Details)
Jacek retitled this revision from [RFC] Initial commit of rocm-opencl for T6614 to Initial commit of rocm-opencl for T6614.
This revision was automatically updated to reflect the committed changes.

Not yet included in repo. Waiting on the solbuild version on the buildserver to be updated first.

Pushed now that the buildserver solbuild got updated.