Page MenuHomeSolus

Initial commit of rocm-compilersupport for T6614
ClosedPublic

Authored by Jacek on Apr 23 2022, 8:27 PM.
Tags
None
Referenced Files
F11037216: D13162.id32667.diff
Wed, Aug 9, 8:16 PM
F11037214: D13162.id32164.diff
Wed, Aug 9, 8:16 PM
F11037213: D13162.id32701.diff
Wed, Aug 9, 8:16 PM
F11037212: D13162.id32178.diff
Wed, Aug 9, 8:16 PM
F11037211: D13162.id32601.diff
Wed, Aug 9, 8:16 PM
F11037210: D13162.id32370.diff
Wed, Aug 9, 8:16 PM
F11037209: D13162.id32702.diff
Wed, Aug 9, 8:16 PM
F11037208: D13162.id32213.diff
Wed, Aug 9, 8:16 PM

Details

Summary

For T6614
Depends on D13161

Test Plan

Compiled rest of rocm with it

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4072
Build 4072: arc lint + arc unit

Event Timeline

Jacek requested review of this revision.Apr 23 2022, 8:27 PM

Clean up, ready for review

Jacek retitled this revision from WIP of rocm-compilersupport for T6614 to [RFC] Initial commit of rocm-compilersupport for T6614.Apr 24 2022, 3:51 PM
Girtablulu added a subscriber: Girtablulu.

Maintainer file

This revision now requires changes to proceed.Apr 27 2022, 9:43 AM
This revision is now accepted and ready to land.May 22 2022, 1:39 PM

Update patches for LLVM 14 and add rocm-cmake

@Jacek I get the following error while building:

In file included from /home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.cpp:36:
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.h:40:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:160: CMakeFiles/amd_comgr.dir/src/comgr-metadata.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-disassembly.cpp:37:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:118: CMakeFiles/amd_comgr.dir/src/comgr-disassembly.cpp.o] Error 1
In file included from /home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr.cpp:41:
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.h:40:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:90: CMakeFiles/amd_comgr.dir/src/comgr.cpp.o] Error 1
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-objdump.cpp:61:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:174: CMakeFiles/amd_comgr.dir/src/comgr-objdump.cpp.o] Error 1
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-compiler.cpp:72:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:76: CMakeFiles/amd_comgr.dir/src/comgr-compiler.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:303: CMakeFiles/amd_comgr.dir/all] Error 2
make: *** [Makefile:166: all] Error 2
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-buildobNC2w']' returned non-zero exit status 2

Oh nevermind I'm using LLVM 13. That's very dumb of me...

Oh nevermind I'm using LLVM 13. That's very dumb of me...

This is a valid point though. I had it patched for LLVM 13, but decided to remove it and wait for LLVM 14, as my GPU isn't supported in 13 and I can't test it.
You can get the patch for building with 13 here though, if you want to try it.
I hope that is all that you need.

joebonrichie added a subscriber: joebonrichie.
joebonrichie added inline comments.
pspec_x86_64.xml
26

Probably don't need to ship these text files

This revision now requires changes to proceed.Jul 16 2022, 9:29 AM

Remove unnecessary textfiles

joebonrichie retitled this revision from [RFC] Initial commit of rocm-compilersupport for T6614 to Initial commit of rocm-compilersupport for T6614.

Not RFC

This revision is now accepted and ready to land.Jul 20 2022, 4:25 PM