Page MenuHomeSolus

[RFC] Initial commit of rocm-compilersupport for T6614
AcceptedPublic

Authored by Jacek on Apr 23 2022, 8:27 PM.

Details

Reviewers
Girtablulu
Group Reviewers
Triage Team
Summary

For T6614
Depends on D13161

Test Plan

Compiled rest of rocm with it

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3779
Build 3779: arc lint + arc unit

Event Timeline

Jacek created this revision.Apr 23 2022, 8:27 PM
Jacek requested review of this revision.Apr 23 2022, 8:27 PM
Jacek updated this revision to Diff 32178.Apr 24 2022, 3:33 PM

Clean up, ready for review

Jacek retitled this revision from WIP of rocm-compilersupport for T6614 to [RFC] Initial commit of rocm-compilersupport for T6614.Apr 24 2022, 3:51 PM
Girtablulu requested changes to this revision.Apr 27 2022, 9:43 AM
Girtablulu added a subscriber: Girtablulu.

Maintainer file

This revision now requires changes to proceed.Apr 27 2022, 9:43 AM
Jacek updated this revision to Diff 32213.Apr 27 2022, 11:35 AM

Add MAINTAINERS.md

Girtablulu accepted this revision.May 22 2022, 1:39 PM
This revision is now accepted and ready to land.May 22 2022, 1:39 PM
Jacek updated this revision to Diff 32370.Mon, May 30, 2:23 PM

Update patches for LLVM 14 and add rocm-cmake

@Jacek I get the following error while building:

In file included from /home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.cpp:36:
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.h:40:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:160: CMakeFiles/amd_comgr.dir/src/comgr-metadata.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-disassembly.cpp:37:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:118: CMakeFiles/amd_comgr.dir/src/comgr-disassembly.cpp.o] Error 1
In file included from /home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr.cpp:41:
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.h:40:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:90: CMakeFiles/amd_comgr.dir/src/comgr.cpp.o] Error 1
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-objdump.cpp:61:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:174: CMakeFiles/amd_comgr.dir/src/comgr-objdump.cpp.o] Error 1
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-compiler.cpp:72:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:76: CMakeFiles/amd_comgr.dir/src/comgr-compiler.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:303: CMakeFiles/amd_comgr.dir/all] Error 2
make: *** [Makefile:166: all] Error 2
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-buildobNC2w']' returned non-zero exit status 2

Oh nevermind I'm using LLVM 13. That's very dumb of me...

Jacek added a comment.Wed, Jun 22, 1:32 PM

Oh nevermind I'm using LLVM 13. That's very dumb of me...

This is a valid point though. I had it patched for LLVM 13, but decided to remove it and wait for LLVM 14, as my GPU isn't supported in 13 and I can't test it.
You can get the patch for building with 13 here though, if you want to try it.
I hope that is all that you need.