Page MenuHomeSolus

Initial commit of rocm-compilersupport for T6614
ClosedPublic

Authored by Jacek on Apr 23 2022, 8:27 PM.
Tags
None
Referenced Files
F11007828: D13162.diff
Tue, Aug 1, 10:20 PM
F10947976: D13162.id32702.diff
Sat, Jul 15, 6:35 PM
F10914948: D13162.id32178.diff
Jul 8 2023, 4:37 AM
F10914905: D13162.id32213.diff
Jul 8 2023, 4:26 AM
F10867844: D13162.diff
Jun 17 2023, 9:00 PM
F10828472: D13162.id32164.diff
Jun 4 2023, 9:30 AM
F10827133: D13162.id32601.diff
Jun 4 2023, 4:35 AM
F10795291: D13162.id32667.diff
May 27 2023, 8:06 PM

Details

Summary

For T6614
Depends on D13161

Test Plan

Compiled rest of rocm with it

Diff Detail

Repository
R5563 rocm-compilersupport
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Jacek requested review of this revision.Apr 23 2022, 8:27 PM

Clean up, ready for review

Jacek retitled this revision from WIP of rocm-compilersupport for T6614 to [RFC] Initial commit of rocm-compilersupport for T6614.Apr 24 2022, 3:51 PM
Girtablulu added a subscriber: Girtablulu.

Maintainer file

This revision now requires changes to proceed.Apr 27 2022, 9:43 AM
This revision is now accepted and ready to land.May 22 2022, 1:39 PM

Update patches for LLVM 14 and add rocm-cmake

@Jacek I get the following error while building:

In file included from /home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.cpp:36:
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.h:40:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:160: CMakeFiles/amd_comgr.dir/src/comgr-metadata.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-disassembly.cpp:37:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:118: CMakeFiles/amd_comgr.dir/src/comgr-disassembly.cpp.o] Error 1
In file included from /home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr.cpp:41:
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-metadata.h:40:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:90: CMakeFiles/amd_comgr.dir/src/comgr.cpp.o] Error 1
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-objdump.cpp:61:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:174: CMakeFiles/amd_comgr.dir/src/comgr-objdump.cpp.o] Error 1
/home/build/YPKG/root/rocm-compilersupport/build/ROCm-CompilerSupport-rocm-5.1.0/lib/comgr/src/comgr-compiler.cpp:72:10: fatal error: 'llvm/MC/TargetRegistry.h' file not found
#include "llvm/MC/TargetRegistry.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/amd_comgr.dir/build.make:76: CMakeFiles/amd_comgr.dir/src/comgr-compiler.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:303: CMakeFiles/amd_comgr.dir/all] Error 2
make: *** [Makefile:166: all] Error 2
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-buildobNC2w']' returned non-zero exit status 2

Oh nevermind I'm using LLVM 13. That's very dumb of me...

Oh nevermind I'm using LLVM 13. That's very dumb of me...

This is a valid point though. I had it patched for LLVM 13, but decided to remove it and wait for LLVM 14, as my GPU isn't supported in 13 and I can't test it.
You can get the patch for building with 13 here though, if you want to try it.
I hope that is all that you need.

joebonrichie added a subscriber: joebonrichie.
joebonrichie added inline comments.
pspec_x86_64.xml
26

Probably don't need to ship these text files

This revision now requires changes to proceed.Jul 16 2022, 9:29 AM

Remove unnecessary textfiles

joebonrichie retitled this revision from [RFC] Initial commit of rocm-compilersupport for T6614 to Initial commit of rocm-compilersupport for T6614.

Not RFC

This revision is now accepted and ready to land.Jul 20 2022, 4:25 PM