Page MenuHomeSolus

Update bismuth to 3.1.1
ClosedPublic

Authored by biqqles on Apr 12 2022, 12:19 AM.

Details

Summary

Release notes:

Test Plan

Restarted kwin, tiling still works.

Diff Detail

Repository
R5455 bismuth
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

biqqles created this revision.Apr 12 2022, 12:19 AM
biqqles requested review of this revision.Apr 12 2022, 12:19 AM
Staudey requested changes to this revision.Apr 12 2022, 5:55 PM
Staudey added a subscriber: Staudey.

Just two minor things:

  1. You have a typo in the title/commit message ("bismith" instead of "bismuth")
  2. Let's switch to our macros for the whole package build, see inline comment
package.yml
27

While you're at it, you can use our macros throughout the whole process, like so:

setup      : |
    npm install
    %cmake_ninja
build      : |
    %ninja_build
install    : |
    %ninja_install
This revision now requires changes to proceed.Apr 12 2022, 5:55 PM
biqqles updated this revision to Diff 32072.Apr 12 2022, 9:23 PM

Requested changes

biqqles retitled this revision from Update bismith to 3.1.1 to Update bismuth to 3.1.1.Apr 12 2022, 9:23 PM
biqqles marked an inline comment as done.
biqqles added inline comments.
package.yml
27

This is clean, thanks

biqqles marked an inline comment as done.Apr 12 2022, 9:26 PM
Staudey accepted this revision.Apr 12 2022, 11:07 PM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 12 2022, 11:07 PM
This revision was automatically updated to reflect the committed changes.