Page MenuHomeSolus

Update jabref to 5.5
ClosedPublic

Authored by biqqles on Apr 11 2022, 11:38 PM.

Details

Summary

Took me a while but quite pleased with this, to be honest. Seemingly managed to avoid this mess over on AUR. Plus this means we get to kill openjfx-8, which is gratifying after the irritation it caused when updating the ruby stack last.

Release notes:

Depends on D13108
Part of T10227

Test Plan

Launch the application from the menu, open About dialog.

Diff Detail

Repository
R1494 jabref
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

biqqles created this revision.Apr 11 2022, 11:38 PM
biqqles requested review of this revision.Apr 11 2022, 11:38 PM
biqqles edited the summary of this revision. (Show Details)Apr 11 2022, 11:41 PM
ReillyBrogan added inline comments.
files/jabref.desktop
1–2

This field has nothing to do with the package version, but instead the version of the Freedesktop desktop entry specification that the .desktop file conforms to: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html

You should honestly just delete the key entirely as I don't think anything actually cares about it and it's likely to confuse people further in the future.

3

Using a wrapper script like ipscan uses would probably be a better approach.

Something like this:

#!/bin/sh

if [ -z "$JAVA_HOME" ]; then
    export JAVA_HOME=/usr/lib64/openjdk-17
fi

exec /usr/share/jabref/bin/JabRef "$@"

Which would allow the user to override the JAVA_HOME themselves if they chose to.

package.yml
13

You should keep gradle as a build dep and change the ./gradlew command to gradle instead so it uses the system gradle instead of the wrapper.

biqqles added inline comments.Apr 12 2022, 5:31 PM
files/jabref.desktop
1–2

How interesting, I have written several desktop files before and never knew that!

3

Will do this, also allows launch from shell

package.yml
13

Bit of an issue here

* What went wrong:
Could not compile settings file '/home/build/YPKG/root/jabref/build/jabref-5.5/settings.gradle'.
> startup failed:
  General error during semantic analysis: Unsupported class file major version 61

gradle is 6.8.3 but given the choice jabref uses 7.3.3

ReillyBrogan added inline comments.Apr 13 2022, 4:28 PM
package.yml
13

OK, use the bundled gradle wrapper but keep gradle as a builddep and add a note that it needs a newer version of gradle. I'm going to be bumping gradle as part of the Java stack update so when we move onto the part where build tooling uses jdk-17 by default and removing explicit JAVA_HOME and related variables we can switch this package to system gradle.

biqqles updated this revision to Diff 32096.Apr 15 2022, 11:32 AM

Requested changes

biqqles marked 3 inline comments as done.Apr 15 2022, 11:33 AM
ReillyBrogan requested changes to this revision.Apr 15 2022, 5:40 PM
ReillyBrogan added inline comments.
package.yml
28–30

I think you forgot to add jabref.sh to your diff

This revision now requires changes to proceed.Apr 15 2022, 5:40 PM
biqqles updated this revision to Diff 32097.Apr 15 2022, 11:01 PM

Include wrapper

Oops, yes, I'm so used to just doing add -u

biqqles marked 2 inline comments as done.Apr 15 2022, 11:05 PM
Girtablulu accepted this revision.Apr 20 2022, 8:58 PM
Girtablulu added a subscriber: Girtablulu.

LGTM, thx

This revision is now accepted and ready to land.Apr 20 2022, 8:58 PM
This revision was automatically updated to reflect the committed changes.