Page MenuHomeSolus
Differential D13126

Initial commit for dart
Needs ReviewPublic
Actions

Authored by GZGavinZhao on Apr 11 2022, 9:21 PM.
Tags
Referenced Files
F11006617: D13126.diff
Tue, Aug 1, 4:15 PM
F11003968: D13126.diff
Mon, Jul 31, 8:42 PM
F10989312: D13126.diff
Mon, Jul 24, 2:41 PM
F10975430: D13126.diff
Sat, Jul 22, 5:02 AM
F10975150: D13126.diff
Sat, Jul 22, 3:58 AM
F10863419: D13126.diff
Jun 17 2023, 2:17 AM
F10829384: D13126.diff
Jun 4 2023, 11:59 AM
F10805711: D13126.diff
May 29 2023, 9:44 PM
View All 49 Files
Subscribers
algent
EbonJaeger
infinitymdm
Jacek
joebonrichie
ReillyBrogan
Staudey
TClark77
Tokens
"Party Time" token, awarded by Jacek.

Details

Reviewers
None
Group Reviewers
Triage Team
Maniphest Tasks
T4974: Dartlang
Summary

Fixes T4974.

Test Plan

Compiled and ran various programs to JS and executable, such as AngularDart, webdev, and dart-sass. Flutter was not tested because it has its own requirements on the version of the SDK.

Signed-off-by: Gavin Zhao <git@gzgz.dev>

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4325
Build 4325: arc lint + arc unit

Event Timeline

GZGavinZhao created this revision.Apr 11 2022, 9:21 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptApr 11 2022, 9:21 PM
GZGavinZhao requested review of this revision.Apr 11 2022, 9:21 PM
Harbormaster completed remote builds in B3710: Diff 32067.Apr 11 2022, 9:21 PM
EbonJaeger added a subscriber: EbonJaeger.Apr 11 2022, 9:31 PM
Staudey added a subscriber: Staudey.Apr 16 2022, 10:28 PM
GZGavinZhao updated this revision to Diff 32330.May 17 2022, 1:44 AM

Yipee my IT department was kind enough to lent me a 2TB hard drive, so my computer is now alive and back!

Back to the topic: the time stamp issue occured because it was not a stable build. I have verified that after I build a stable version of the Dart SDK, the time stamp appears.

Ready for review o(^▽^)o

Harbormaster completed remote builds in B3878: Diff 32330.May 17 2022, 1:44 AM
GZGavinZhao retitled this revision from [WIP] Initial commit for dart to Initial commit for dart.May 17 2022, 1:44 AM
GZGavinZhao edited the summary of this revision. (Show Details)
GZGavinZhao updated this revision to Diff 32331.May 17 2022, 1:45 AM

Add MAINTAINERS.md.

Harbormaster completed remote builds in B3879: Diff 32331.May 17 2022, 1:45 AM
GZGavinZhao edited the summary of this revision. (Show Details)May 17 2022, 2:05 AM
GZGavinZhao planned changes to this revision.May 23 2022, 10:40 PM

The time stamp is inconsistence. Needs further investigation.

GZGavinZhao added a comment.Jun 17 2022, 9:07 PM

Welp, the new GCC broke the build... I have to investigate that.

joebonrichie added a subscriber: joebonrichie.Jun 17 2022, 10:12 PM

it's okay you can build with clang :)

infinitymdm added a subscriber: infinitymdm.Jul 9 2022, 7:10 PM
GZGavinZhao added a comment.Jul 26 2022, 4:36 AM

Was able to make force it to build with system Clang! After I solve the time stamp issue everything should be ready,

Jacek awarded a token.Jul 26 2022, 10:53 AM
GZGavinZhao updated this revision to Diff 32759.Jul 27 2022, 3:21 AM

All done!

Harbormaster completed remote builds in B4120: Diff 32759.Jul 27 2022, 3:21 AM
GZGavinZhao edited the summary of this revision. (Show Details)Jul 27 2022, 3:23 AM
GZGavinZhao updated this revision to Diff 32760.Jul 27 2022, 3:24 AM

Add the mysteriously disappeared MAINTAINERS.md.

Harbormaster completed remote builds in B4121: Diff 32760.Jul 27 2022, 3:24 AM
ReillyBrogan added a subscriber: ReillyBrogan.Jul 27 2022, 4:50 AM
ReillyBrogan added inline comments.
dartlang-solus-tarball.sh
63–65

I wouldn't recommend using sed with specific lines because it'll end up being very fragile and will break with any changes to that file. I'd recommend trying to patch that file instead perhaps replacing the logic so that the "fallback" is the only option.

GZGavinZhao updated this revision to Diff 33031.Aug 24 2022, 12:43 AM

Use patch files and separate files in /usr/bin into the -devel package.

Harbormaster completed remote builds in B4285: Diff 33031.Aug 24 2022, 12:43 AM
joebonrichie added a comment.Aug 24 2022, 9:09 AM

Built this locally the other day and found out solbuild supports file:// URIs no problem. e.g. file:///home/foo/solus/dart/dartlang-2.17.6.tar.zst

Jacek added a subscriber: Jacek.Aug 24 2022, 11:25 AM
In D13126#231434, @joebonrichie wrote:

Built this locally the other day and found out solbuild supports file:// URIs no problem. e.g. file:///home/foo/solus/dart/dartlang-2.17.6.tar.zst

No way! This will make testing some changes so much easier!

GZGavinZhao updated this revision to Diff 33101.Aug 31 2022, 8:24 PM
GZGavinZhao marked an inline comment as done.

Update to Dart 2.18.0.

Harbormaster completed remote builds in B4324: Diff 33101.Aug 31 2022, 8:24 PM
GZGavinZhao updated this revision to Diff 33102.Aug 31 2022, 8:26 PM

Update link to our own source tarball.

Harbormaster completed remote builds in B4325: Diff 33102.Aug 31 2022, 8:26 PM
TClark77 added a project: Software.May 29 2023, 12:38 AM
TClark77 added a subscriber: TClark77.
algent added a subscriber: algent.Wed, Jul 19, 9:19 PM

Please use the new MAINTAINERS.md file.

Revision Contents
Changeset List

Diff 33102

View Options

MAINTAINERS.md

Loading...
View Options

Makefile

Loading...
View Options

abi_libs

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_symbols

Loading...
View Options

dartlang-solus-tarball.sh

Loading...
View Options

files/Add-Timestamp-And-Git-Revision-Fallback.patch

Loading...
View Options

files/Force-Always-No-Sysroot.patch

Loading...
View Options

files/Use-System-Clang.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.