Page MenuHomeSolus

Initial commit for dart
Changes PlannedPublic

Authored by GZGavinZhao on Apr 11 2022, 9:21 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Maniphest Tasks
T4974: Dartlang
Summary

Fixes T4974.

Finally, a patch was landed that indirectly fixed building with GCC (i.e. it was supposed to enable RISC-V support but happens to fix some code that was causing trouble with GCC).

I could not figure out a way to do a Clang build because any attempt will either be ignored by the Dart build tool or cause the build system to use the clang provided upstream by Dart. Since I'm not seeing any notable differences or problems, we can use GCC for now and switch to clang once I find out what is wrong.

Performance-wise: our package is only a tiny few seconds slower than the upstream version compiled by Clang. My testing on an Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz shows that dart-sass, one of the largest pure-Dart software I can find, compiles in 10.216s while the upstream version compiles in 9.955s. Similarly, the default AngularDart (a Dart web framework) example project compiles in 58.981s while the upstream version compiles in 58.654s. Therefore, I would say there is no severe performance lost here despite us using GCC.

Test Plan

Compiled and ran various programs to JS and executable, such as AngularDart, webdev, and dart-sass. Flutter was not tested because it has its own requirements on the version of the SDK.

Signed-off-by: Gavin Zhao <git@gzgz.dev>

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3879
Build 3879: arc lint + arc unit

Event Timeline

GZGavinZhao created this revision.Apr 11 2022, 9:21 PM
GZGavinZhao requested review of this revision.Apr 11 2022, 9:21 PM

Yipee my IT department was kind enough to lent me a 2TB hard drive, so my computer is now alive and back!

Back to the topic: the time stamp issue occured because it was not a stable build. I have verified that after I build a stable version of the Dart SDK, the time stamp appears.

Ready for review o(^▽^)o

GZGavinZhao retitled this revision from [WIP] Initial commit for dart to Initial commit for dart.Tue, May 17, 1:44 AM
GZGavinZhao edited the summary of this revision. (Show Details)

Add MAINTAINERS.md.

GZGavinZhao edited the summary of this revision. (Show Details)Tue, May 17, 2:05 AM
GZGavinZhao planned changes to this revision.Mon, May 23, 10:40 PM

The time stamp is inconsistence. Needs further investigation.