Page MenuHomeSolus

libnfnetlink 1.0.1
ClosedPublic

Authored by czb on Nov 3 2017, 10:40 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T5036: NetfilterQueue
Commits
R3928:4e60119a6733: libnfnetlink 1.0.1
Summary

It's a library needed by libnetfilter_queue.

Test Plan

Built libnetfilter_queue.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

czb created this revision.Nov 3 2017, 10:40 PM
czb retitled this revision from Version 1.0.1 to libnfnetlink 1.0.1.Nov 3 2017, 10:41 PM
JoshStrobl requested changes to this revision.Nov 3 2017, 10:43 PM
JoshStrobl added a subscriber: JoshStrobl.

It's a library needed by libnetfilter_queue.

And that's required for what? Because I'm not seeing a package request for it.

package.yml
7

GPL-2.0

10
not >
This revision now requires changes to proceed.Nov 3 2017, 10:43 PM
JoshStrobl added inline comments.Nov 3 2017, 10:45 PM
package.yml
10

Apparently phab doesn't like a lonely | character. > should be |

czb added a comment.Nov 3 2017, 11:01 PM

libnetfilter_queue is needed to install python package NetfilterQueue. I can make a request for that if it helps.

czb updated this revision to Diff 3196.Nov 3 2017, 11:10 PM
czb edited edge metadata.

Changed license code and description formatting.

czb updated this revision to Diff 3197.Nov 3 2017, 11:12 PM

Add missing, updated pspec.

libnetfilter_queue is needed to install python package NetfilterQueue

Yes, as per our submitting a package documentation, patches shouldn't be submitted for applications that aren't accepted for inclusion yet (and since you haven't submitted a package request yet, it hasn't been accepted).

JoshStrobl edited the summary of this revision. (Show Details)Nov 18 2017, 5:39 PM
JoshStrobl requested changes to this revision.Nov 18 2017, 5:41 PM

Okay so, confused by this. Your package request references python-netfilterqueue. Are those just python bindings for this library, or the library itself? If they're different, please update T5036 with libnfnetlink info rather than the binding.

Also you need a test plan.

This revision now requires changes to proceed.Nov 18 2017, 5:41 PM
czb added a comment.EditedNov 18 2017, 6:41 PM

Well, what I need personally is python package NetfilterQueue which provides bindings for libnetfilter_queue and needs libnetfilter_queue to be installed. This package, libnfnetlink, is libnetfilter_queue's dependency, so what I planned was to package it first and then package libnetfilter_queue. Should I change then T5036 to package request for libnetfilter_queue or it's dependency?

czb updated this revision to Diff 3448.Nov 18 2017, 6:45 PM
czb edited edge metadata.
czb edited the test plan for this revision. (Show Details)

Added test plan.

No it's fine but I'd suggest building these packages from source using the local repo functionality in solbuild and providing those other packages as patches as well (use Phabricator's stack functionality to create a graph of what depends on what, use "Depends on Dblahblah", where blahblah is the differential number, such as 1309. Once we get those patches, I'll re-review this again and we can see about landing it :)

czb added a comment.Nov 20 2017, 1:24 PM

Ok, I'll try to do that in the next weeks.

Awesome! Looking forward to the patches =)

czb edited the summary of this revision. (Show Details)Dec 3 2017, 1:02 PM
JoshStrobl accepted this revision.Dec 28 2017, 6:09 PM
This revision is now accepted and ready to land.Dec 28 2017, 6:09 PM
This revision was automatically updated to reflect the committed changes.