Page MenuHomeSolus

libnfnetlink 1.0.1
ClosedPublic

Authored by czb on Nov 3 2017, 10:40 PM.
Tags
None
Referenced Files
F11023906: D1309.diff
Tue, Aug 8, 5:26 PM
F11004650: D1309.diff
Tue, Aug 1, 2:54 AM
F10993372: D1309.diff
Tue, Jul 25, 4:52 PM
F10941680: D1309.id3196.diff
Fri, Jul 14, 7:16 AM
F10897147: D1309.id3448.diff
Jul 2 2023, 4:47 AM
F10897069: D1309.id.diff
Jul 2 2023, 4:15 AM
F10897064: D1309.id3196.diff
Jul 2 2023, 4:14 AM
F10897060: D1309.id3197.diff
Jul 2 2023, 4:12 AM
Subscribers

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T5036: NetfilterQueue
Commits
R3928:4e60119a6733: libnfnetlink 1.0.1
Summary

It's a library needed by libnetfilter_queue.

Test Plan

Built libnetfilter_queue.

Diff Detail

Repository
R3928 libnfnetlink
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

czb retitled this revision from Version 1.0.1 to libnfnetlink 1.0.1.Nov 3 2017, 10:41 PM
JoshStrobl added a subscriber: JoshStrobl.

It's a library needed by libnetfilter_queue.

And that's required for what? Because I'm not seeing a package request for it.

package.yml
7

GPL-2.0

10
not >
This revision now requires changes to proceed.Nov 3 2017, 10:43 PM
package.yml
10

Apparently phab doesn't like a lonely | character. > should be |

libnetfilter_queue is needed to install python package NetfilterQueue. I can make a request for that if it helps.

czb edited edge metadata.

Changed license code and description formatting.

Add missing, updated pspec.

libnetfilter_queue is needed to install python package NetfilterQueue

Yes, as per our submitting a package documentation, patches shouldn't be submitted for applications that aren't accepted for inclusion yet (and since you haven't submitted a package request yet, it hasn't been accepted).

Okay so, confused by this. Your package request references python-netfilterqueue. Are those just python bindings for this library, or the library itself? If they're different, please update T5036 with libnfnetlink info rather than the binding.

Also you need a test plan.

This revision now requires changes to proceed.Nov 18 2017, 5:41 PM

Well, what I need personally is python package NetfilterQueue which provides bindings for libnetfilter_queue and needs libnetfilter_queue to be installed. This package, libnfnetlink, is libnetfilter_queue's dependency, so what I planned was to package it first and then package libnetfilter_queue. Should I change then T5036 to package request for libnetfilter_queue or it's dependency?

czb edited edge metadata.
czb edited the test plan for this revision. (Show Details)

Added test plan.

No it's fine but I'd suggest building these packages from source using the local repo functionality in solbuild and providing those other packages as patches as well (use Phabricator's stack functionality to create a graph of what depends on what, use "Depends on Dblahblah", where blahblah is the differential number, such as 1309. Once we get those patches, I'll re-review this again and we can see about landing it :)

Ok, I'll try to do that in the next weeks.

Awesome! Looking forward to the patches =)

This revision is now accepted and ready to land.Dec 28 2017, 6:09 PM
This revision was automatically updated to reflect the committed changes.