It's a library needed by libnetfilter_queue.
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T5036: NetfilterQueue
- Commits
- R3928:4e60119a6733: libnfnetlink 1.0.1
Built libnetfilter_queue.
Diff Detail
Diff Detail
- Repository
- R3928 libnfnetlink
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| package.yml | ||
|---|---|---|
| 10 | Apparently phab doesn't like a lonely | character. > should be | | |
Comment Actions
libnetfilter_queue is needed to install python package NetfilterQueue. I can make a request for that if it helps.
Comment Actions
libnetfilter_queue is needed to install python package NetfilterQueue
Yes, as per our submitting a package documentation, patches shouldn't be submitted for applications that aren't accepted for inclusion yet (and since you haven't submitted a package request yet, it hasn't been accepted).
Comment Actions
Okay so, confused by this. Your package request references python-netfilterqueue. Are those just python bindings for this library, or the library itself? If they're different, please update T5036 with libnfnetlink info rather than the binding.
Also you need a test plan.
Comment Actions
Well, what I need personally is python package NetfilterQueue which provides bindings for libnetfilter_queue and needs libnetfilter_queue to be installed. This package, libnfnetlink, is libnetfilter_queue's dependency, so what I planned was to package it first and then package libnetfilter_queue. Should I change then T5036 to package request for libnetfilter_queue or it's dependency?
Comment Actions
No it's fine but I'd suggest building these packages from source using the local repo functionality in solbuild and providing those other packages as patches as well (use Phabricator's stack functionality to create a graph of what depends on what, use "Depends on Dblahblah", where blahblah is the differential number, such as 1309. Once we get those patches, I'll re-review this again and we can see about landing it :)