Differential D13068

curl: Build gnutls version in the same package
Needs ReviewPublic
Actions

Authored by livingsilver94 on Mar 26 2022, 11:44 PM.

Details

Reviewers

None

Group Reviewers

Triage Team

Summary

Build gnutls version in the same package.

Test Plan

No ABI or file changes compared to the curl-gnutls git repository.

Diff Detail

Repository

R578 curl

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 3818
Build 3818: arc lint + arc unit

Event Timeline

livingsilver94 created this revision.Mar 26 2022, 11:44 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 26 2022, 11:44 PM

Harbormaster completed remote builds in B3639: Diff 31953.Mar 26 2022, 11:44 PM

livingsilver94 requested review of this revision.Mar 26 2022, 11:44 PM

I know this will need a rebase against the glibc rebuild, but let me push this differential as a backup.

Blocked on T10232.

Rebase

Harbormaster completed remote builds in B3718: Diff 32083.Apr 13 2022, 9:49 PM

I forgot to pull libgnutls into the dep list :P

Harbormaster completed remote builds in B3726: Diff 32092.Apr 14 2022, 5:15 PM

To be rebased. Again.

Rebase

Harbormaster completed remote builds in B3818: Diff 32233.Apr 30 2022, 9:44 AM

Hello?

Ping.

This looks to me to be a nice way to consolidate our build recipes, even though it makes this particular one a bit uglier. When I brought it up internally there wasn't any resistance either. I'll have a closer look at your patch details this weekend, test it, and check whether it correctly replaces the current package from the separate recipe, but if you're still willing to update this (rebase it on master), I think we can merge it in soon-ish.