Differential D13040

fifechan: remove unneeded builddep on Irrlicht
ClosedPublic
Actions

Authored by aleksvor on Mar 19 2022, 9:28 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

R747:0f1415ca5204: fifechan: remove unneeded builddep on Irrlicht

Summary

Remove build dependency on irrlicht - it's optional and was never used in our build.
Depends on D13034.

Test Plan

Tested that fifechan builds correctly. Can't test if it works, since unknown-horizons don't work atm due to another issue.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Mar 19 2022, 9:28 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 19 2022, 9:28 PM

aleksvor requested review of this revision.Mar 19 2022, 9:28 PM

Harbormaster completed remote builds in B3608: Diff 31879.Mar 19 2022, 9:28 PM

LGTM, thx

This revision is now accepted and ready to land.Mar 20 2022, 1:52 PM

Closed by commit R747:0f1415ca5204: fifechan: remove unneeded builddep on Irrlicht (authored by aleksvor, committed by Girtablulu). · Explain WhyMar 20 2022, 1:53 PM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R747:0f1415ca5204: fifechan: remove unneeded builddep on Irrlicht.

Revision Contents
Changeset List

			Path	Packages
M			abi_used_symbols (9 lines)
M			package.yml (3 lines)
M			pspec_x86_64.xml (14 lines)

Diff 31911

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...