Differential D13034

irrlicht: switch to IrrlichtMt
ClosedPublic
Actions

Authored by aleksvor on Mar 19 2022, 6:37 PM.

Details

Reviewers

Girtablulu

Group Reviewers

Triage Team

Commits

R1485:175ec73232e8: irrlicht: switch to IrrlichtMt

Summary

Replace irrlicht with irrlichtmt.
Minetest forked Irrlicht and switched to using it. Upstream Irrlicht is mostly abandoned, and it was only used by Minetest in our repo, so original Irrlicht can be safely deprecated.

Test Plan

Built and tested minetest against it.

Diff Detail

Repository

R1485 irrlichtmt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Mar 19 2022, 6:37 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 19 2022, 6:37 PM

aleksvor requested review of this revision.Mar 19 2022, 6:37 PM

Harbormaster completed remote builds in B3601: Diff 31872.Mar 19 2022, 6:37 PM

Deprecation PR here.

aleksvor added a child revision: D13035: Update minetest to 5.5.0.Mar 19 2022, 6:42 PM

fifechan also has a build dependency on irrlicht-devel it seems. I haven't yet checked whether it actually still needs it.

P.S. fifechan is only used by fifengine and unknown-horizons, which don't work atm anyway (due to another issue)

@Staudey, fifechan optionally supports Irrlicht, but it was never used in our build - it requires specific flag to be enabled (see here), and abi-wizard shows that our fifechan was never built against it. I will submit a diff with removed dependency.

aleksvor added a child revision: D13040: fifechan: remove unneeded builddep on Irrlicht.Mar 19 2022, 9:28 PM

Okay, that's what I suspected, but didn't have time to check it out. Thanks for taking care of that!

LGTM, thx

This revision is now accepted and ready to land.Mar 20 2022, 1:52 PM

Closed by commit R1485:175ec73232e8: irrlicht: switch to IrrlichtMt (authored by aleksvor, committed by Girtablulu). · Explain WhyMar 20 2022, 1:52 PM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R1485:175ec73232e8: irrlicht: switch to IrrlichtMt.

Revision Contents
Changeset List

			Path	Packages
M			abi_libs (2 lines)
M			abi_symbols (6186 lines)
M			abi_used_libs (2 lines)
M			abi_used_symbols (82 lines)
M			package.yml (26 lines)
M			pspec_x86_64.xml (369 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31872	1ab256a		Mar 19 2022, 6:37 PM	★	★
Diff 2	31910	1ab256a	R1485:175ec73232e833e6a06f547eea18e5a1d3179507	Mar 20 2022, 1:52 PM	★	★

Status	Author	Revision
Closed	aleksvor	D13035 Update minetest to 5.5.0
Closed	aleksvor	D13040 fifechan: remove unneeded builddep on Irrlicht
Closed	aleksvor	D13034 irrlicht: switch to IrrlichtMt