Page MenuHomeSolus

irrlicht: switch to IrrlichtMt
ClosedPublic

Authored by aleksvor on Mar 19 2022, 6:37 PM.

Details

Summary

Replace irrlicht with irrlichtmt.
Minetest forked Irrlicht and switched to using it. Upstream Irrlicht is mostly abandoned, and it was only used by Minetest in our repo, so original Irrlicht can be safely deprecated.

Test Plan

Built and tested minetest against it.

Diff Detail

Repository
R1485 irrlichtmt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Mar 19 2022, 6:37 PM
aleksvor requested review of this revision.Mar 19 2022, 6:37 PM

Deprecation PR here.

fifechan also has a build dependency on irrlicht-devel it seems. I haven't yet checked whether it actually still needs it.

P.S. fifechan is only used by fifengine and unknown-horizons, which don't work atm anyway (due to another issue)

@Staudey, fifechan optionally supports Irrlicht, but it was never used in our build - it requires specific flag to be enabled (see here), and abi-wizard shows that our fifechan was never built against it. I will submit a diff with removed dependency.

Okay, that's what I suspected, but didn't have time to check it out. Thanks for taking care of that!

Girtablulu accepted this revision.Mar 20 2022, 1:52 PM
Girtablulu added a subscriber: Girtablulu.

LGTM, thx

This revision is now accepted and ready to land.Mar 20 2022, 1:52 PM
This revision was automatically updated to reflect the committed changes.