Page MenuHomeSolus

Update libusb to 1.0.25
ClosedPublic

Authored by MalteJoe on Mar 17 2022, 7:46 PM.

Details

Summary

Summary:
Update libusb to 1.0.25
Fixes T10198

Feature Improvements:

  • New NO_DEVICE_DISCOVERY option to replace WEAK_AUTHORITY option

Bug Fixes:

  • [regression 1.0.24] can't communicate with iPhone/iPad on Linux
  • Regression in libusb 1.0.24 under Linux -- buggy devices with configuration 0
  • Regression in 1.0.24: libusb_handle_events_timeout_completed not waiting on timeout
  • Regression in 1.0.24: libusb 1.0.24 uses a lot of cpu in libusb_bulk_transfer under Linux

Signed-off-by: Malte Jörgens <malte358@gmail.com>

Test Plan

used XBOX wireless dongle to connect a wireless controller and launch Steam Big Picture with it

Diff Detail

Repository
R1880 libusb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

MalteJoe created this revision.Mar 17 2022, 7:46 PM
MalteJoe requested review of this revision.Mar 17 2022, 7:47 PM
Staudey requested changes to this revision.Mar 17 2022, 8:06 PM
Staudey added a subscriber: Staudey.

Could you please mention the changes for this version in your summary? Something like:

**Changes:**
- Change 1
- Change 2
- etc.

But please don't include the ones for other operating systems. We only care about those that affect Linux/Solus. (sometimes it makes sense to simply link to the changelog, but in this case it's small enough to be quoted in full)

FYI you don't necessarily have to create a task if you're going to submit a patch anyway, but I guess it's good to see what kind of issues should be fixed by this.

This revision now requires changes to proceed.Mar 17 2022, 8:06 PM
MalteJoe updated this revision to Diff 31861.Mar 17 2022, 8:42 PM

Added Changelog

MalteJoe edited the summary of this revision. (Show Details)Mar 17 2022, 8:43 PM
MalteJoe edited the summary of this revision. (Show Details)
MalteJoe edited the test plan for this revision. (Show Details)

Thanks, I added the items of the changelog with core/Linux tags, so maybe you can take another look?

FYI you don't necessarily have to create a task if you're going to submit a patch anyway, but I guess it's good to see what kind of issues should be fixed by this.

Thanks for the heads-up, I wasn't planning to submit my first patch when I created the task. But then I decided to check out contributing, how hard could it be :D

just remove the github issue numbers now e.g. #123, otherwise looks good

MalteJoe edited the summary of this revision. (Show Details)Mar 17 2022, 9:43 PM
MalteJoe edited the summary of this revision. (Show Details)Mar 17 2022, 10:00 PM
MalteJoe edited the summary of this revision. (Show Details)
Staudey accepted this revision.Mar 17 2022, 10:51 PM

Looks good to me now, thanks!

Congrats on your first patch 😉

This revision is now accepted and ready to land.Mar 17 2022, 10:51 PM
This revision was automatically updated to reflect the committed changes.