Differential D12928

Initial inclusion of Babashka resolves T10072
ClosedPublic
Actions

Authored by oly on Feb 21 2022, 7:45 PM.

Tags

None

Referenced Files

	F10972542: D12928.diff
	Fri, Jul 21, 2:13 PM

	F10938511: D12928.id31534.diff
	Thu, Jul 13, 3:23 PM

	F10866759: D12928.diff
	Jun 17 2023, 5:07 PM

	F10842285: D12928.id31585.diff
	Jun 10 2023, 11:13 AM

	F10842038: D12928.id31576.diff
	Jun 10 2023, 9:59 AM

	F10840715: D12928.id31534.diff
	Jun 10 2023, 2:53 AM

	F10828049: D12928.diff
	Jun 4 2023, 8:17 AM

	F10794822: D12928.id31585.diff
	May 27 2023, 5:43 PM

View All 12 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T10072: Inclusion of Babashka

Commits

R5480:b1aba2f16363: Initial inclusion of Babashka resolves T10072

Summary

Inclusion of Babashka clojure command line scripting language.

Fixes T10072

Test Plan

Installd generated eopkg and ran /usr/bin/bb -e "(prn \"hello\")" to test

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

oly created this revision.Feb 21 2022, 7:45 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 21 2022, 7:45 PM

Harbormaster completed remote builds in B3410: Diff 31534.Feb 21 2022, 7:45 PM

oly requested review of this revision.Feb 21 2022, 7:45 PM

Girtablulu requested changes to this revision.Feb 23 2022, 9:57 PM

Girtablulu added a subscriber: Girtablulu.

Girtablulu added inline comments.

package.yml
6	please use the tar file
7	empty line

This revision now requires changes to proceed.Feb 23 2022, 9:57 PM

Removed blank line.

Harbormaster completed remote builds in B3439: Diff 31576.Feb 24 2022, 5:24 AM

oly marked an inline comment as done.Feb 24 2022, 5:27 AM

oly added inline comments.

package.yml
6	I originally used the tar how ever the tar does not contain the sub modules required to build the project, I spoke to the project author and he explained that to build I would need to pull in these files. Open to other options if this is still an issue ?

no, then it's fine we just prefer using a tar but if upstream doesn't ship it with a tar we have to use git :)

the rest LGTM, thx

This revision is now accepted and ready to land.Feb 24 2022, 9:06 PM

Girtablulu edited the summary of this revision. (Show Details)Feb 24 2022, 9:06 PM

Girtablulu added a task: T10072: Inclusion of Babashka.

Closed by commit R5480:b1aba2f16363: Initial inclusion of Babashka resolves T10072 (authored by oly, committed by Girtablulu). · Explain WhyFeb 24 2022, 9:08 PM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R5480:b1aba2f16363: Initial inclusion of Babashka resolves T10072.

Revision Contents
Changeset List

Path

Size

1 line

1 line

31 lines

7 lines

abi_used_symbols

223 lines

26 lines

pspec_x86_64.xml

34 lines

Diff 31585

Makefile

Loading...

abi_libs

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...