Page MenuHomeSolus

Update sqlitebrowser to 3.10.1
ClosedPublic

Authored by frbuceta on Nov 1 2017, 6:56 PM.
Tags
None
Referenced Files
F11018571: D1290.id3294.diff
Sun, Aug 6, 1:14 PM
F11012789: D1290.id3296.diff
Fri, Aug 4, 6:37 AM
F10974530: D1290.id3296.diff
Sat, Jul 22, 12:55 AM
F10970823: D1290.id3421.diff
Fri, Jul 21, 4:19 AM
F10970651: D1290.id3297.diff
Fri, Jul 21, 3:32 AM
F10963009: D1290.id3422.diff
Wed, Jul 19, 1:27 AM
F10958811: D1290.diff
Tue, Jul 18, 2:59 AM
F10958239: D1290.id3162.diff
Mon, Jul 17, 11:39 PM

Details

Summary

Official Changelog Here

Changelog:

Upgrade sqlitebrowser 3.9.1 to 3.10.1
Change Qt4 to Qt5
Add libraries
Test Plan

Functions such as opening, modifying and applying databases have been tried. The result has been satisfactory

Diff Detail

Repository
R2956 sqlitebrowser
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.
  1. You should provide a summarized changelog and a test plan.
  2. You should be using pkgconfigs and eliminating the Qt5Core pkgconfig when you update the qt5-tools entry, since tools requires base.
This revision now requires changes to proceed.Nov 9 2017, 5:58 PM
frbuceta edited the test plan for this revision. (Show Details)
frbuceta edited the summary of this revision. (Show Details)
frbuceta edited edge metadata.
joebonrichie added a subscriber: joebonrichie.
joebonrichie added inline comments.
package.yml
15–16

Should use pkgconfigs, and make sure they're alphabetised

eopkg info libglu-devel
eopkg info qt5-tools-devel

This revision now requires changes to proceed.Nov 11 2017, 3:00 PM
frbuceta edited edge metadata.

One last thing, you need to update your test plan to verify the application is working as normal.

This revision now requires changes to proceed.Nov 11 2017, 3:59 PM

Yes, this version I have installed on my computer and it seems to work all.
The only thing is that sometimes does not let me minimize but otherwise everything is correct.

Neither your changelog or test plan are helpful, and the gif isn't necessary.

Your changelog needs to explain what changed in the software and your test plan needs to explain how you tested it, what you did within the app.

frbuceta edited the test plan for this revision. (Show Details)
frbuceta edited edge metadata.

Could you just replace the summary with a link to the changelog following the markdown syntax [text](URL)

This revision now requires changes to proceed.Nov 16 2017, 8:10 PM
frbuceta edited the summary of this revision. (Show Details)
frbuceta edited edge metadata.
joebonrichie requested changes to this revision.EditedNov 16 2017, 8:28 PM

I just build this locally and libQt5Test.so.5 got added to abi_used_libs can do you a rebuild and update the diff if qt5test shows up?

This revision now requires changes to proceed.Nov 16 2017, 8:28 PM
frbuceta edited edge metadata.

Add libQt5Test.so.5

This revision was automatically updated to reflect the committed changes.