Initial inclusion of Heroic Games Launcher, an open source alternative to Epic Games Launcher and GOG. Fixes T9656
Details
Details
- Reviewers
Staudey - Maniphest Tasks
- T9656: Heroic Games Launcher
- Commits
- R5491:d583ebf3bcc5: Initial inclusion of Heroic Games Launcher
- Package Heroic using make with the unstable repository.
- Install the resulting package using sudo eopkg it.
- Verify that the app appears in the system menu (may require reboot).
- Launch the app from the system menu.
- Mess around in the UI a bit to make sure things look ok. If possible, log into Epic / GOG account(s), configure a wine/proton version, and install & test a game.
- Close Heroic, then launch a terminal and execute heroic.
- Verify that the application launches and information is logged to the terminal.
- Close the application and verify that the logs stop.
- In the terminal, execute legendary.
- Verify that usage information appears for legendary.
- In the terminal, execute gogdl.
- Verify that usage information appears for gogdl.
Diff Detail
Diff Detail
- Repository
- R5491 heroic-games-launcher
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Add fixes for package.yml and heroic.desktop
Removes redundant dependencies and adds newlines at EOF as suggested by joebonrichie.
Comment Actions
@joebonrichie Out of curiosity, how are you checking whether dependencies are redundant?
Edit: The reason I ask is so that I can improve my process in the future. This is my first time getting involved and I'd love to learn how I can do better.
Comment Actions
I can't help but notice that this hasn't been touched since I implemented the requested changes last week. Are you guys waiting on me to do something else?
Comment Actions
You can clean more builddeps. This is a boring process you have to check them all.
One of my practices is to use this alias to search about the pkgconfigs: alias epc='$HOME/Repository/common/Scripts/epcsearch.py'.
And then just type epc atk and get the result:
pkgconfig(atk) found in: libatk-devel
Then eopkg info libatk-devel will tell that at-spi2-atk-devel is one of the revdeps. It means that at-spi2-atk-devel which is pkgconfig(atk-bridge-2.0) pull libatk-devel during installation of dependencies.
So here you can remove pkgconfig(atk) from builddeps in the package.yml file.
Comment Actions
Removed unnecessary dependencies
Removed the following from package.yml:
- pkgconfig(atk)
- pkgconfig(atspi-2)
- pkgconfig(gbm)
Comment Actions
This helped a lot. I think everything is good now. Please correct me if I'm wrong.
Yes, the deps are cleaned.
Comment Actions
I'd love to get this included in this week's sync. If there are issues please let me know, and I'll patch them up right away.
Comment Actions
Forgive me if I'm incorrect, I'm new to this... but is this not moving forward because T9305 needs to be completed first? If so, I'll get to work on that.
Comment Actions
@infinitymdm No, I don't think that is the reason. Your package, or rather the Heroic Games Launcher project, bundles Legendary. Since nothing else in the repository makes use of Legendary, that might be an acceptable situation. If there are ever other tools relying on it, then it would sense to split it into its own package. The reason your diff has not yet been accepted is most likely the simple fact that nobody had time yet to look at your newest changes and test them. FWIW functionality-wise it seems to work fine in its current state (just tested it).
Comment Actions
Ok. I just didn't know how long the process was supposed to take, and I was concerned by the lack of feedback. I will be patient. Thanks!
Comment Actions
I have been using this for a bit now and it seems to work fine. Therefore LGTM. Thank you for being patient!
Comment Actions
Thanks!
I noticed that the authorship for this is being attributed to a user "marcus". My name is Marcus, so that's half correct, but I am not that user. I assume this won't have any affects on maintainership, so it's not a huge deal, but I'd appreciate it if that could be fixed.
Comment Actions
I noticed that the authorship for this is being attributed to a user "marcus". My name is Marcus, so that's half correct, but I am not that user. I assume this won't have any affects on maintainership, so it's not a huge deal, but I'd appreciate it if that could be fixed.
Huh, good catch. I'll try to see if I can fix that. To be honest I have no idea (yet) why the tooling did that (it's not like we manually insert the author there).
Edit: Could it be that you're not registered with your gmail email address here, and that the author name for your local git config is simply "marcus"? In that case I can see how phabricator might've picked the wrong author.
Edit2: Nevermind I can just check the commit. Yup, different email and username simply "Marcus". This makes the email check fail and the username check picks the wrong person (since your username is also different). Unfortunately I haven't yet found a way to correct this.
Comment Actions
Once again, not a huge deal as long as it doesn't change maintainership. For future updates then, I just need to make sure my local git config has the correct user.name and user.email set, correct?
Comment Actions
No, maintainership is not affected. This is just an unfortunate little issue with the automatic assignment of authorship.
Yes, if you could set your git email address to the same you have on phabricator (which I presume is the one in your MAINTAINERS.md) then the tools should correctly identify you as author for the next commit.
Comment Actions
Well, the good news is that there was a new release of Heroic today, so I'll make sure to fix that before committing. Thanks for your help.
Comment Actions
Thanks a lot, and sorry for the additional trouble. Unfortunately it seems like I still can't fix it for the original commit (but of course the Diff and everything relating to it is linked in the commit, so someone checking it out can see the actual author, i.e. you)
I just hope that the other "Marcus" isn't too confused when he notices it ^^