package.yml
11	nit: would prefer a slightly more descriptive description, from their github README: "sysbench is a scriptable multi-threaded benchmark tool based on LuaJIT. It is most frequently used for database benchmarks, but can also be used to create arbitrarily complex workloads that do not involve a database server."
18	nit: we have an `%autogen` macro which you can use instead. With that you can drop the configure macro and pass the configure options to autogen instead.

This revision now requires changes to proceed.Feb 15 2022, 11:23 AM

nazar updated this revision to Diff 31415.Feb 15 2022, 1:00 PM

With these warnings means I typically won't be able to run arc land on this cleanly

Lint was skipped when generating these changes.
Unit tests were skipped when generating these changes.

In D12804#219136, @joebonrichie wrote:

With these warnings means I typically won't be able to run arc land on this cleanly

I lost .git directory and had to upload raw diff (via phab) to fix provided remarks.

Would it work (for you) if I re-create this patch?

yes please

this patch is abandoned now, continue with D12896

Harvey abandoned this revision.Feb 16 2022, 1:19 AM

Revision Contents
Changeset List

Path

Size

5 lines

1 line

9 lines

226 lines

21 lines

117 lines

Diff 31415

View Options

MAINTAINERS.md

View Options

Makefile

View Options

abi_used_libs

View Options

abi_used_symbols

View Options

package.yml

View Options

initial inclusion of sysbenchAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31415

MAINTAINERS.md

Makefile

abi_used_libs

abi_used_symbols

package.yml

pspec_x86_64.xml

initial inclusion of sysbench
AbandonedPublic
Actions

Revision Contents
Changeset List