Zotero is a free, easy-to-use tool to help you collect, organize, cite, and share your research sources. Resolves T685
Details
Details
- Reviewers
kyrios123 Girtablulu - Group Reviewers
Triage Team - Maniphest Tasks
- T685: Zotero
- Commits
- R5484:8c02d072017f: initial inclusion of Zotero
build & install, add file, export "My library.bib"
Diff Detail
Diff Detail
- Repository
- R5484 zotero
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Few small changes needed
| package.yml | ||
|---|---|---|
| 9 | Use a SPDX correct licence identifier e.g. AGPL-3.0-only or AGPL-3.0-or-later https://spdx.org/licenses/ In this case it looks like or-later. | |
| 16 | nit: unneeded builddep | |
| 18 | nit: would prefer you to pull in the pkgconfig e.g. pkgconfig(python3) just for consistency across the solus repo. | |
| 19–20 | Are these needed? Fine if they are, just feels a bit weird. Also remember alphabetical order 0-9A-za-z pkgconfigs first. | |
| 56 | Please use octal permissions for solus packaging e.g. 00755, 00644, etc. | |
Comment Actions
Mostly LGTM, just one more clarification needed.
| pspec_x86_64.xml | ||
|---|---|---|
| 93 | Does it use a custom poppler-data? Can it not use our system poppler-data package? | |
| package.yml | ||
|---|---|---|
| 58 | You install from $installdir to another location in $installdir meaning you duplicate the files. Is it required to have the files twice? Also the .desktop file is broken (path to the zotero binary, .ico file for the icon) | |
| pspec_x86_64.xml | ||
|---|---|---|
| 93 | Unless we decide to patch source code, zotero expects poppler-data embedded. See https://github.com/zotero/zotero/blob/52932b6eb03f72b5fb5591ba52d8e0f4c2ef825f/chrome/content/zotero/xpcom/fulltext.js#L84 PS. Good catch! | |
| package.yml | ||
|---|---|---|
| 20 | For what are these needed? I test build it without all the rundeps and it seems to run totally fine | |
Comment Actions
From all rundeps libgtk-3 and libxt probably can stay. The others aren't needed because they are pulled by libgtk-3 and some are part of system.base.
Comment Actions
@nazar I built this package a few times, and confirmed that rundeps aren't needed at all. But you have to add some builddeps to fix errors like:
Fatal: Unknown symbol: libgtk-x11-2.0.so.0 Fatal: Unknown symbol: libgdk-x11-2.0.so.0
Builddeps that I used are:
builddeps :
- pkgconfig(gtk+-2.0)
- pkgconfig(gtk+-3.0)
- pkgconfig(python3)
- pkgconfig(xt)
- nodejs
- rsync
- wgetAll needed rundeps will be linked automatically:
Dependencies : dbus libxcomposite libxcursor libstdc++ libgcc libxcb libgtk-2 libgtk-3 pango dbus-glib glib2
freetype2 libcairo libxi glibc libx11 fontconfig gdk-pixbuf libxt libxrender libatk libxdamage
libxext libxfixes| pspec_x86_64.xml | ||
|---|---|---|
| 9 | This is different from package.yml. You have to rebuild the package and not edit manually pspec_x86_64.xml file. | |