Page MenuHomeSolus

initial inclusion of Zotero
ClosedPublic

Authored by nazar on Jan 28 2022, 2:23 PM.

Details

Summary

Zotero is a free, easy-to-use tool to help you collect, organize, cite, and share your research sources. Resolves T685

Test Plan

build & install, add file, export "My library.bib"

Diff Detail

Repository
R5484 zotero
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nazar created this revision.Jan 28 2022, 2:23 PM
nazar requested review of this revision.Jan 28 2022, 2:23 PM
nazar retitled this revision from resolves T685 to Zotero.Jan 28 2022, 2:24 PM
nazar edited the summary of this revision. (Show Details)
nazar edited the test plan for this revision. (Show Details)
nazar added a task: T685: Zotero.
nazar updated this revision to Diff 31152.Jan 28 2022, 2:27 PM

release 1

nazar retitled this revision from Zotero to initial inclusion of Zotero.Jan 28 2022, 2:35 PM
joebonrichie requested changes to this revision.Feb 6 2022, 12:09 PM
joebonrichie added a subscriber: joebonrichie.

Few small changes needed

package.yml
9

Use a SPDX correct licence identifier e.g. AGPL-3.0-only or AGPL-3.0-or-later https://spdx.org/licenses/ In this case it looks like or-later.

16

nit: unneeded builddep

18

nit: would prefer you to pull in the pkgconfig e.g. pkgconfig(python3) just for consistency across the solus repo.

19–20

Are these needed? Fine if they are, just feels a bit weird. Also remember alphabetical order 0-9A-za-z pkgconfigs first.

56

Please use octal permissions for solus packaging e.g. 00755, 00644, etc.

This revision now requires changes to proceed.Feb 6 2022, 12:09 PM
nazar updated this revision to Diff 31301.Feb 6 2022, 4:04 PM

apply requested changes

nazar updated this revision to Diff 31302.Feb 6 2022, 4:09 PM

apply requested changes

Mostly LGTM, just one more clarification needed.

pspec_x86_64.xml
93

Does it use a custom poppler-data? Can it not use our system poppler-data package?

kyrios123 requested changes to this revision.Feb 6 2022, 7:26 PM
kyrios123 added inline comments.
package.yml
58

You install from $installdir to another location in $installdir meaning you duplicate the files. Is it required to have the files twice?
(same with the following install commands)

Also the .desktop file is broken (path to the zotero binary, .ico file for the icon)

This revision now requires changes to proceed.Feb 6 2022, 7:26 PM
nazar updated this revision to Diff 31304.Feb 6 2022, 8:00 PM

fix zotero.desktop file

nazar marked 7 inline comments as done.Feb 22 2022, 3:00 AM
nazar added inline comments.
pspec_x86_64.xml
93

Unless we decide to patch source code, zotero expects poppler-data embedded. See https://github.com/zotero/zotero/blob/52932b6eb03f72b5fb5591ba52d8e0f4c2ef825f/chrome/content/zotero/xpcom/fulltext.js#L84

PS. Good catch!

Girtablulu requested changes to this revision.Feb 24 2022, 10:13 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
20

For what are these needed? I test build it without all the rundeps and it seems to run totally fine

This revision now requires changes to proceed.Feb 24 2022, 10:13 PM
algent added a subscriber: algent.EditedFeb 24 2022, 11:11 PM

From all rundeps libgtk-3 and libxt probably can stay. The others aren't needed because they are pulled by libgtk-3 and some are part of system.base.

nazar updated this revision to Diff 31607.Feb 25 2022, 5:44 AM
nazar marked an inline comment as done.

fix rundeps

joebonrichie resigned from this revision.Feb 25 2022, 11:53 AM
joebonrichie removed a reviewer: joebonrichie.

@nazar I built this package a few times, and confirmed that rundeps aren't needed at all. But you have to add some builddeps to fix errors like:

Fatal: Unknown symbol: libgtk-x11-2.0.so.0
Fatal: Unknown symbol: libgdk-x11-2.0.so.0

Builddeps that I used are:

builddeps  :
    - pkgconfig(gtk+-2.0)
    - pkgconfig(gtk+-3.0)
    - pkgconfig(python3)
    - pkgconfig(xt)
    - nodejs
    - rsync
    - wget

All needed rundeps will be linked automatically:

Dependencies        : dbus libxcomposite libxcursor libstdc++ libgcc libxcb libgtk-2 libgtk-3 pango dbus-glib glib2
                      freetype2 libcairo libxi glibc libx11 fontconfig gdk-pixbuf libxt libxrender libatk libxdamage
                      libxext libxfixes
nazar updated this revision to Diff 31611.Feb 25 2022, 3:30 PM

fix builddeps

algent added inline comments.Feb 25 2022, 4:06 PM
pspec_x86_64.xml
9

This is different from package.yml. You have to rebuild the package and not edit manually pspec_x86_64.xml file.

Also there are a lot of ABI changes, a rebuild is a must.

kyrios123 edited the test plan for this revision. (Show Details)Feb 25 2022, 7:44 PM
algent removed a subscriber: algent.Feb 25 2022, 8:24 PM
nazar updated this revision to Diff 31618.Feb 25 2022, 10:00 PM

rebuild

nazar updated this revision to Diff 31619.Feb 26 2022, 5:01 AM

rebuild

kyrios123 accepted this revision as: kyrios123.Feb 26 2022, 2:24 PM
kyrios123 awarded a token.
Girtablulu accepted this revision.Feb 26 2022, 4:28 PM

LGTM, thx

This revision is now accepted and ready to land.Feb 26 2022, 4:28 PM
This revision was automatically updated to reflect the committed changes.