Differential D12775

Correct lein so it works when .lein_classpath is not present.
ClosedPublic
Actions

Authored by oly on Jan 24 2022, 8:41 PM.

Tags

None

Referenced Files

	F10974555: D12775.diff
	Sat, Jul 22, 1:01 AM

	F10866774: D12775.diff
	Jun 17 2023, 5:12 PM

	F10841982: D12775.id31108.diff
	Jun 10 2023, 9:42 AM

	F10841866: D12775.id31100.diff
	Jun 10 2023, 9:11 AM

	F10836801: D12775.diff
	Jun 8 2023, 8:35 PM

	F10762626: D12775.id31108.diff
	May 18 2023, 7:29 PM

	F10744379: D12775.diff
	May 15 2023, 12:24 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

R5432:a5750ab0a120: Correct lein so it works when .lein_classpath is not present.

Summary

This was built incorrectly it only worked if a project happened to
have .lein_classpath preset speaking to the project author I found out
you need to build the core then build the top level project to get a
correct cmd line tool with all the tasks available.

Test Plan

Ran make then installed the eopkg, ran "lein new project" from tmp to create a new project from the default template.

Diff Detail

Repository

R5432 leiningen

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

oly created this revision.Jan 24 2022, 8:41 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 24 2022, 8:41 PM

oly requested review of this revision.Jan 24 2022, 8:41 PM

Harbormaster completed remote builds in B3154: Diff 31100.Jan 24 2022, 8:41 PM

Girtablulu requested changes to this revision.Jan 24 2022, 9:13 PM

Girtablulu added a subscriber: Girtablulu.

Girtablulu added inline comments.

package.yml
3	Needs to be bump

This revision now requires changes to proceed.Jan 24 2022, 9:13 PM

Bump the package version.

Harbormaster completed remote builds in B3161: Diff 31108.Jan 25 2022, 12:24 PM

oly marked an inline comment as done.Jan 25 2022, 6:22 PM

LGTm, thx

This revision is now accepted and ready to land.Jan 26 2022, 8:38 AM

Closed by commit R5432:a5750ab0a120: Correct lein so it works when .lein_classpath is not present. (authored by oly, committed by Girtablulu). · Explain WhyJan 26 2022, 8:39 AM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R5432:a5750ab0a120: Correct lein so it works when .lein_classpath is not present..

Revision Contents
Changeset List

Path

Size

files/

60 lines

	project_core.clj
	project.clj

12 lines

pspec_x86_64.xml

4 lines

Diff 31113

files/project.clj

Loading...

files/project_core.clj

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...